Spec URL: http://kwizart.fedorapeople.org/review/perl-Net-CIDR.spec SRPM URL: http://kwizart.fedorapeople.org/review/perl-Net-CIDR-0.13-1.fc12.src.rpm Description: Manipulate IPv4/IPv6 netblocks in CIDR notation
Looks OK at first glance except License: should be "GPL+ or Artistic". Full review to follow.
perl-Net-CIDR review: rpmlint output: perl-Net-CIDR.noarch: W: invalid-license Distributable, see COPYING perl-Net-CIDR.src: W: invalid-license Distributable, see COPYING These needs fixing, by changing the license tag to "GPL+ or Artistic" - package and spec file naming OK - package meets guidelines - package is licensed same as perl but license tag needs fixing to reflect this - no upstream license text to include, though the COPYING file refers to the licenses under which the software is licensed, and this file is included - spec file written in English and is legible - source matches upstream - package builds OK in mock for Rawhide x86_64 - buildreqs OK - no locale data, shared or static libs, or devel files to worry about - package not relocatable - no duplicate files or directory ownership issues - %defattr(...) present and correct - %clean section present and correct - macro usage is consistent - code, not content - no large docs - not a GUI app -> no desktop file needed - buildroot cleaned correctly at the start of %install - filenames all ASCII - no scriptlets or subpackages Notes: * License should be "GPL+ or Artistic" * No point including Net-CIDR.spec as %doc * Why use wildcards for single items in %files list: %{perl_vendorlib}/* could be %{perl_vendorlib}/Net/ %{_mandir}/man3/* could be %{_mandir}/man3/Net::CIDR.3pm* This is just a style issue really but IMHO the more explicit entries are more readable and informative Only the license issue is a blocker here. Fix that and I'll approve.
Spec URL: http://kwizart.fedorapeople.org/review/perl-Net-CIDR.spec SRPM URL: http://kwizart.fedorapeople.org/review/perl-Net-CIDR-0.13-2.fc11.src.rpm Description: Manipulate IPv4/IPv6 netblocks in CIDR notation Changelog: - Fix License tag - Remove Net-CIDR.spec from %%doc - List files more explicitely
rpmlint now clean. APPROVED.
New Package CVS Request ======================= Package Name: perl-Net-CIDR Short Description: Manipulate IPv4/IPv6 netblocks in CIDR notation Owners: kwizart Branches: F-12 F-11 F-10 EL-5 InitialCC: perl-sig
cvs done.
perl-Net-CIDR-0.13-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/perl-Net-CIDR-0.13-2.fc12
perl-Net-CIDR-0.13-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-Net-CIDR-0.13-2.fc11
perl-Net-CIDR-0.13-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/perl-Net-CIDR-0.13-2.fc10
perl-Net-CIDR-0.13-2.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/perl-Net-CIDR-0.13-2.el5
perl-Net-CIDR-0.13-2.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-Net-CIDR'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2009-0842
perl-Net-CIDR-0.13-2.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-Net-CIDR'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-11412
perl-Net-CIDR-0.13-2.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-Net-CIDR'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2009-11423
perl-Net-CIDR-0.13-2.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-Net-CIDR'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-11429
perl-Net-CIDR-0.13-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
perl-Net-CIDR-0.13-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
perl-Net-CIDR-0.13-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
perl-Net-CIDR-0.13-2.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request ====================== Package Name: perl-Net-CIDR New Branches: epel7 Owners: pghmcfc InitialCC: perl-sig Nicolas is ok with me taking the EPEL branch: https://bugzilla.redhat.com/show_bug.cgi?id=1163610#c4
Git done (by process-git-requests).
perl-Net-CIDR-0.17-6.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/perl-Net-CIDR-0.17-6.el7
perl-Net-CIDR-0.17-6.el7 has been pushed to the Fedora EPEL 7 stable repository.