Spec URL: http://students.mimuw.edu.pl/~ab277290/Fedora/bwa.spec SRPM URL: http://students.mimuw.edu.pl/~ab277290/Fedora/bwa-0.5.4-1.fc12.src.rpm Description: I just packaged bwa (I think correctly). It's my first package, so I appreciate any suggestions what could be improved. Burrows-Wheeler Aligner (BWA) is an efficient program that aligns relatively short nucleotide sequences against a long reference sequence such as the human genome.
Hi Albert, I'm not a sponsor, but I do have some suggestions: 1. Package did not build for me by default: http://boodle.fedorapeople.org/RPMS/bwa_install_error.out 2. Source0: should point to URL, please see: http://fedoraproject.org/wiki/Packaging/SourceURL 3. You can add this to your make: CFLAGS="$RPM_OPT_FLAGS" Then it will compile. 4. For the %install: You can use install instead of cp, for example: install -Dp -m0755 bwa %{buildroot}/%{_bindir}/ and change the permissions to whatever you'd like. After these changes, rpmlint is clean: $ rpmlint bwa.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint bwa.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings.
I think it should work now.
(In reply to comment #2) > I think it should work now. I still had errors building. http://boodle.fedorapeople.org/RPMS/bwa2_errors Try changing your make line to: make %{?_smp_mflags} \ CFLAGS="$RPM_OPT_FLAGS" Then it compiles. I'm happy to test again once you've made the change. Everything else looks OK to me. Perhaps someone with more experience would like to give it a once over?
Thanks for help. Fixed that, hope it's fine now.
(In reply to comment #4) > Thanks for help. Fixed that, hope it's fine now. works for me now. One more thing, in your spec file you have % files listed twice: %files %defattr(-,root,root,-) %doc COPYING NEWS ChangeLog %{_bindir}/* %files devel %defattr(-,root,root,-) %{_includedir}/* You can get rid of one and compress it down to: %files %defattr(-,root,root,-) %doc COPYING NEWS ChangeLog %{_bindir}/* %{_includedir}/* rpmlint has one more trivial warning: $ rpmlint bwa.spec bwa.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 20, tab: line 1) 0 packages and 1 specfiles checked; 0 errors, 1 warnings. Go ahead and fix that, then I think you are good to go.
(In reply to comment #5) > (In reply to comment #4) > > Thanks for help. Fixed that, hope it's fine now. > > works for me now. One more thing, in your spec file you have % files listed > twice: > > %files > %defattr(-,root,root,-) > %doc COPYING NEWS ChangeLog > %{_bindir}/* > > %files devel > %defattr(-,root,root,-) > %{_includedir}/* > > > You can get rid of one and compress it down to: > > %files > %defattr(-,root,root,-) > %doc COPYING NEWS ChangeLog > %{_bindir}/* > %{_includedir}/* > Sorry, missed the %files devel tag, nevermind the comment above. %files devel is fine. That just leaves the rpmlint warning. > rpmlint has one more trivial warning: > > $ rpmlint bwa.spec > bwa.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 20, tab: line 1) > 0 packages and 1 specfiles checked; 0 errors, 1 warnings. > > Go ahead and fix that, then I think you are good to go.
Fixed, no tabs now. I only get a warning about no documentation for the devel package.
(In reply to comment #7) > Fixed, no tabs now. I only get a warning about no documentation for the devel > package. Great. Thanks Albert. At this point you just need an "offical" review and approval. It looks good to me. Is there anyone with some time who can review please?
I will take a look, though I'm not a sponsor, just a packager.
Albert, Oops - I was in a rush to package this at work and submitted a review request, having forgotten about this existing request. It's now been accepted: https://bugzilla.redhat.com/show_bug.cgi?id=597315 Sorry about that. Hope it's useful to you, at least.
Since Adam's package has been accepted, I'm closing this review request. Albert, if you're still interested in joining the Fedora packager group, please feel free to submit another package. *** This bug has been marked as a duplicate of bug 597315 ***