Bug 534026 - [RFE] Add rhMakefileRequiredCheck() function
Summary: [RFE] Add rhMakefileRequiredCheck() function
Keywords:
Status: CLOSED DUPLICATE of bug 772622
Alias: None
Product: Fedora
Classification: Fedora
Component: beakerlib
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Petr Muller
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-11-10 08:23 UTC by Eduard Benes
Modified: 2016-09-20 02:05 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2013-04-09 16:36:00 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Eduard Benes 2009-11-10 08:23:12 UTC
If RHTS lab manager fails to provide package, it won't be installed on the affected System Under Test (SUT), while the test will be run anyway and thus fail.

It would be nice to have a helper function that would check for presence (installed on the SUT) of all required packages against Makefile and fail if this requirement is not satisfied. This way it won't be necessary to duplicate the list of packages required by the test in the test script and Makefile, and later test for presence using provided asserts.

Such function would enhance a setup phase and overall sanity checks by providing straight forward check for all required packages. Plus, this feature seems to be easy to implement.

Comment 1 Petr Muller 2009-11-16 13:43:20 UTC
Seems quite useful. I'll consider if I add it to the internal plugin or to original beakerlib...

Comment 2 Petr Šplíchal 2009-11-18 08:33:31 UTC
To me it seems better to be an internal hack only, as this is
quite tightly connected to our infrastructure (there's not much
said, well actually nothing, about Makefile format in BeakerLib
manual):

    https://fedorahosted.org/beaker/wiki/BeakerLib/Manual

Either way, I'd vote for a name resembling rlAssertRpm, perhaps
something like:

    rlAssertRpmAll
    rlAssertRpmRequired
    rlAssertRpmAllRequired

Comment 3 Eduard Benes 2009-11-18 09:36:45 UTC
(In reply to comment #2)
> To me it seems better to be an internal hack only, as this is
> quite tightly connected to our infrastructure (there's not much
> said, well actually nothing, about Makefile format in BeakerLib
> manual):
> 
>     https://fedorahosted.org/beaker/wiki/BeakerLib/Manual
> 
> Either way, I'd vote for a name resembling rlAssertRpm, perhaps
> something like:
> 
>     rlAssertRpmAll
>     rlAssertRpmRequired
>     rlAssertRpmAllRequired  

In case you are not going to support RHTS test format directly, which describes the Makefile, it makes sense to add just to the beaker-lib-redhat for internal use only. 

Speaking about the naming scheme, I really don't care, name it as you prefer, and document it somewhere, please.

Comment 5 Petr Muller 2013-04-09 16:36:00 UTC

*** This bug has been marked as a duplicate of bug 772622 ***


Note You need to log in before you can comment on or make changes to this bug.