Hello I am attaching a tarball that contains patches for mlx4 drivers (mlx4_core and mlx4_en) that were created against kernel 2.6.18-172 The main changes: -Additional Ethtool support (self diagnostics test) -Bug fixes -Performance improvements -Giving interface name in driver prints -Have a separate file for Ethtool functionality -SRIOV support
Created attachment 368458 [details] mlx4_patches
Any update on this? Thanks Tziporet
The bug is in post state, which implicitly means that the code has been submitted internally for review and inclusion in the next kernel release.
in kernel-2.6.18-181.el5 You can download this test kernel from http://people.redhat.com/dzickus/el5 Please update the appropriate value in the Verified field (cf_verified) to indicate this fix has been successfully verified. Include a comment with verification details.
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux maintenance release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Update release for currently deployed products. This request is not yet committed for inclusion in an Update release.
@Mellanox We would like to confirm that you can provide commitment to test for the resolution of this request during the RHEL 5.5 Beta Test Phase before we approve it for acceptance into the release. It appears that this request covers areas we are unable to sufficiently test in-house. RHEL 5.5 Beta Test Phase is expected to begin around February 2010. In order to avoid any unnecessary delays, please post a confirmation as soon as possible, including the contact information for testing engineers. Any additional information about alternative testing variations we could use to reproduce this issue in-house would be appreciated.
We most definitely plan to test all the new code in house. We already do it the patches we sent you with the Updated RH5.5 kernels. We have some fixes that we plan on sending in the near week. we will post the fixes to this bug. The engineers working on this in Mellanox are: Yevgeny Petrilin (yevgenyp.il) and Erez Shitrit (erezsh.il) We will need additional contacts if needed.
Created attachment 389347 [details] SRIOV fixes for mlx4_core and mlx4_en drivers
Hello, I have attached a patch created on top of 2.6.18-182 kernel with fixes to our SRIOV code. This code is being tested and verified inside Mellanox, and we will send fixes if there are more issues found. The attached fixes were also sent to upstream kernel and currently reviewed by Roland Dreier : http://marc.info/?l=linux-netdev&m=126529887700754&w=2
~~ Attention Customers and Partners - RHEL 5.5 Beta is now available on RHN ~~ RHEL 5.5 Beta has been released! There should be a fix present in this release that addresses your request. Please test and report back results here, by March 3rd 2010 (2010-03-03) or sooner. Upon successful verification of this request, post your results and update the Verified field in Bugzilla with the appropriate value. If you encounter any issues while testing, please describe them and set this bug into NEED_INFO. If you encounter new defects or have additional patch(es) to request for inclusion, please clone this bug per each request and escalate through your support representative.
The patches from Comment 11 are not part of this Beta kernel, so at the moment the driver miss-functions. Can these fixes be still done? Thanks, Yevgeny
I just checked the 2.6.18-190 kernel, the mlx4 driver is buggy! The attached fixes need to be accepted to fix it.
Putting back into ON_QA as the follow on patch in comment #11 is being tracked in bug #567730
An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHSA-2010-0178.html
Created attachment 404655 [details] 1/5 patch: Retry when pci resource allocation fails.
Created attachment 404656 [details] patch 2/5: resource alignment management
Created attachment 404657 [details] patch 3/5: sriov resource alignment fix
Created attachment 404658 [details] patch 4/5: track sriov resources through a IORESOURCE_SRIOV flag
Created attachment 404659 [details] patch 5/5: fixes a pci resource allocation bug
the above 5 patches enable SRIOV for mellanox, intel 1g, intel 10g. Have touch tested the code. More testing is needed. Meanwhile any comments/feedback is appreciated.
Created attachment 406119 [details] a corrected version of 4/5 patch. It fixes a issue seen during rmmod/insmod of the driver a corrected version of 4/5 patch. It fixes a issue seen during rmmod/insmod of the driver