mirror the look, feel, functionality: last X units in Y time range (simple) link to details ("advanced settings...") advanced settings page *can* remain a Struts component, since it's a full-page Struts page...or it can be converted to (lean towards not converting it, unless it makes the navigation back to the calling JSF page in some way less convoluted)
this component, when the "advanced settings..." link is clicked, needs to capture the current context / url. store the url in some fashion, and then after the advanced settings are set (or even if cancel is pressed) to forward back to the stored url. this way, the component can be dropped onto ANY page, and it'll "just work".
Fady, As part of this work please add the new metric display range into the new resource and group metrics pages. There are three tables.xhtml: common, resource and group. The latter two embed the first. I think you will probably need to add it to the resource and group pages explicitly but perhaps you can utilize common. Please contact me for any questions regarding these new pages. Thanks, -J
rev2666 - fix persistence of preferences for MetricComponent; remove MetricComponent from UIBean (managed beans need never concern themselves with the existence of this component on their corresponding facelet);
Fixed the metric components and replicated it over the pages. (graphs, tables, events)
from Ian: java.lang.IllegalStateException: Required request parameter 'id' is missing when I try to change the metric display interval using the 'Last n Hours' control on the Graphs or Tables tab. I'm able to change the interval fine using the Change Settings link (i.e. the Advanced controls) ...will attach the trace in a moment.
rev2755 - fix for majority of issues with metric component component; simple metric display works now on monitor>graphs and events>history pages; still need to do more testing around the advanced display;
rev2756 - make metric display range text label match the old monitor tab;
rev2757 - push the updates to user preferences into a managed bean and out of the metric component; remove unnecessary component and renderer logic; change tabs to spaces in advanced-metrics.js; remove UI header from popup.xhtml, so popup feels like a popup instead of a full window; fix the javascript in advanced.xhtml by hooking actions to onchange events instead of onclick; reduce coordination between AdvancedMetricSettingsUIBean and persisted prefs by using units as the backing value of the drop-down list;
rev2760 - add metric display range navigation rules to rest of resource, group, and autogroup pages;
rev2764 - by default, set the begin/end ranges to the "last X units" calculated range, if that's the selected display option; always reset the readonly option in the MetricComponentUtililty to make sure that state of that variable is consistent with the other detailed options;
rev2765 - we don't want to save custom units for the lifetime of the JVM, just until the user chooses some other display range;
i think this component is lookin' pretty good now. been working with it on various monitor and events subtabs at the resource, group, and autogroup levels. resolving for push to QA.
Verified date and time controls work, graphs update according to what you set there. Link back to simple mode works. linked bug i found here. rev2898
This bug was previously known as http://jira.rhq-project.org/browse/RHQ-1051 Imported an attachment (id=368485)