Red Hat Bugzilla – Bug 534321
MonitorUtils.formatMetrics fails to use passed locale
Last modified: 2014-05-02 16:20:38 EDT
MonitorUtilTest tests fail if the server locale is not US :
java.lang.AssertionError: expected:<5.1h> but was:<5,1h>
Looking at the code shows that the test method explicitly asks for US locale, but that the code in
MonitorUtils.formatMetrics(MetricDisplaySummary, Locale) ignores it
MonitorUtils.formatMetrics(List,...) only uses it in one case.
The formatting code is indeed returning the right formatting for my non-US locale.
NOTE: Revision 2179 changes the tests in a way that the returned data (which is in the user locale) gets compared against localized versions of the reference data.
If MonitorUtils.formatMetrics() is fixed, then it will be also necessary to basically revert rev2179.
This bug was previously known as http://jira.rhq-project.org/browse/RHQ-1129
The original issue may or may not still be valid but we need to look into unit conversion and unit labels in the new interface, and taking I18N into consideration.