Bug 534569 (RHQ-1353) - peer review synchronization in org.rhq.core.pluginapi.content.version.PackageVersions
Summary: peer review synchronization in org.rhq.core.pluginapi.content.version.Package...
Keywords:
Status: CLOSED UPSTREAM
Alias: RHQ-1353
Product: RHQ Project
Classification: Other
Component: Plugins
Version: unspecified
Hardware: All
OS: All
medium
medium
Target Milestone: ---
: ---
Assignee: RHQ Project Maintainer
QA Contact:
URL: http://jira.rhq-project.org/browse/RH...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-01-13 14:21 UTC by John Mazzitelli
Modified: 2010-10-26 11:09 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2010-10-26 11:09:30 UTC
Embargoed:


Attachments (Terms of Use)

Description John Mazzitelli 2009-01-13 14:21:00 UTC
Look at the thread safety code in org.rhq.core.pluginapi.content.version.PackageVersions and make sure it is correct.

I just fixed a couple of glaring issues surrounding the unlocking of the RW lock. But there seems to be other issues that I didn't have time to look at.

Look at the access to "data" - sometimes its synchronized, other times not. There is the use of "synchronized" keyword and there is the usage of this RW lock (why both?). The thread safety code here looks haphazard and needs to be peer reviewed (I am not convinced it is 100%correct).

Comment 1 John Mazzitelli 2009-01-13 14:23:25 UTC
svn rev 2608 was my fix that I allueded to in the summary. but again, there is more to be fixed here I think

Comment 2 Red Hat Bugzilla 2009-11-10 20:31:11 UTC
This bug was previously known as http://jira.rhq-project.org/browse/RHQ-1353


Comment 3 wes hayutin 2010-02-16 15:44:57 UTC
mass move off the qa triage list.  These are tasks for dev.

Comment 4 Corey Welton 2010-08-18 15:25:52 UTC
mazz, is this still an issue  - what were your findings/results?

Comment 5 John Mazzitelli 2010-08-24 17:59:25 UTC
master commit fdb272c9ea2544b53a66bb37e99b7f6f9be38487

I fixed what looked to be wrong.  This class does not even seem to be used (Eclipse can't find any references to it, other than from its unit test) so this probably isn't important. Nothing to QA. Just close this out as FIXED-CODE CHANGE.

Comment 6 Sudhir D 2010-10-26 11:09:30 UTC
Closing this as per previous comment.


Note You need to log in before you can comment on or make changes to this bug.