Red Hat Bugzilla – Bug 53584
/etc/rc.d/init.d/pcmcia incorrectly uses insmod
Last modified: 2015-01-04 17:01:27 EST
From Bugzilla Helper: User-Agent: Mozilla/4.76 [en] (X11; U; Linux 2.4.10-pre8-xfs i586) Description of problem: /etc/rc.d/init.d/pcmcia uses insmod with hard coded pathnames to the pcmcia modules. The default is /lib/modules/`uname -r`/pcmcia, that directory will not exist in 2.5 kernels. David Hinds and I agreed that the pcmcia directory would only exist as a short term measure until users had a chance to upgrade their pcmcia packages. The main pcmcia code uses modprobe, not insmod, and lets modutils find the pcmcia modules, no matter where they are. Please remove hard coded paths and replace all usage of insmod with modprobe in init scripts. Version-Release number of selected component (if applicable): How reproducible: Always Steps to Reproduce: 1. rm -rf /lib/modules/`uname -r`/pcmcia 2. /etc/rc.d/init.d/pcmcia restart 3. Actual Results: Cannot find /lib/modules/`uname -r`/pcmcia. Expected Results: Using modprobe instead of insmod, modutils takes care of finding the pcmcia modules. Additional info: In /etc/rc.d/init.d/pcmcia, replace /sbin/insmod $PC/pcmcia_core.o $CORE_OPTS /sbin/insmod $PC/$PCIC.o $PCIC_OPTS /sbin/insmod $PC/ds.o with /sbin/modprobe pcmcia_core $CORE_OPTS /sbin/modprobe $PCIC $PCIC_OPTS /sbin/modprobe ds and delete all references to PC.
While I agree that this needs to be fixed, this file comes from a recent pcmcia-cs package. And anyway, for 2.5 pcmcia will be rewritten from scratch....
Would it be possible to get this fixed now? After all, the bug is still present in the current FC1 initscripts... and bite about anyone using self-built kernels and PCMCIA/CardBus (which translates roughly to everyone using a laptop with an 54mbps WLAN card).
this seems to have got fixed some time ago, and the bugzilla never got updated. These days, the script only does an insmod if modprobe doesn't exist (which should never happen). I'm going to close this, please feel free to reopen if you think theres something that needs fixing in the current trees. The rc.pcmcia script is ugly as all hell, and could use some attention from someone motivated to clean it up, but for the most part it's just redundant stuff that doesn't get run any more that could get removed it seems.
FYI: I've changed this in rawhide to take the latest rc.pcmcia from pcmcia-cs-3.2.7 with the insmod & preferred bits chopped out.