not critical, pushing

This popop looks even worse now - its  url encoded.
We need to fix this.

Joe - didn't you change something recently that might make this message better formatted now? I think it was you that did the url encoding and I think it requires that we change the JSF xhtml to take advantage of it.  Please comment on what needs to be changed.

If we could just get this message to show unencoded with the newlines properly showed, this message would be OK.  The problem has always been the newlines were stripped out and everything ran together.

opps... meant to assign to jay, not me.

jay - is this potentially fixed with some recent changes of yours (or joes?)

not fixed yet - RHQ-1380 was opened (I closed that one because its a duplicate of this one, but that at least tells me this isn't fixed yet)

use RF modal dialogs, e.g:

                  <h:outputLink rendered="#{syncitem.results ne null}"
                                value="#" id="resultsLink">
                     <h:outputText value="Click here to view..."/>
                     <rich:componentControl for="resultsModalPanel" attachTo="resultsLink" operation="show" event="onclick"/>
                  </h:outputLink>
                  <h:outputText rendered="#{syncitem.results eq null}" value=""/>
                  <rich:modalPanel id="resultsModalPanel" width="350" height="300">
                     <f:facet name="header">
                        <h:panelGroup>
                           <h:outputText value="Results" />
                        </h:panelGroup>
                     </f:facet>
                     <f:facet name="controls">
                        <h:panelGroup>
                           <h:graphicImage value="/images/close.png" style="cursor:pointer" id="resultsModelPanelHideLink"/>
                           <rich:componentControl for="resultsModalPanel" attachTo="resultsModelPanelHideLink" operation="hide" event="onclick"/>
                        </h:panelGroup>
                     </f:facet>
                     <PRE><h:outputText value="#{syncitem.results}" /></PRE>
                  </rich:modalPanel>

still haven't figured out a way to get the newlines to render. I really don't want to have to code up some conversion in the UI bean, but I think that's what it will have to end up with.

svn rev3164 fixes the content source page. still need to figure out how to render newlines, but the %20 garbage is gone on this page.

svn rev3166 uses  <pre> tags so the newlines render. this is fine since we are rendering some raw output/logs that looks ok in <pre> tags

Do a search for all .xhtml files that use "javascript:displayMessageModal" - there are alot of them. We should use this RF modal dialog for all of these to maintain consistency.

op-results snapshot shows the problem when looking at the operation results failures

svn rev3504 fixes that op-results failures dialog

svn rev3506 fixes the group op details page

There are now 5 places left in the code that uses this message modal:

configurationUpdate.xhtml - rhq/modules/enterprise/gui/portal-war/src/main/webapp/rhq/subsystem
groupOperationHistory.xhtml - rhq/modules/enterprise/gui/portal-war/src/main/webapp/rhq/group/operation
history.xhtml - rhq/modules/enterprise/gui/portal-war/src/main/webapp/rhq/resource/configuration
history.xhtml - rhq/modules/enterprise/gui/portal-war/src/main/webapp/rhq/resource/inventory
operationHistory.xhtml - rhq/modules/enterprise/gui/portal-war/src/main/webapp/rhq/subsystem

The problem is, all 5 occur inside a rich:dataTable. As such, multiple rows are rendered with this "javascript:displayMessageModal". The problem here is if we have multiple places in the page that render this, we cannot define multiple element ids. We would need to be able to do something like this:

   <h:outputLink rendered="#{syncitem.results ne null}"
      value="#" id="resultsLink" + ROW_INDEX_HERE>
...
      <rich:componentControl for="resultsModalPanel" attachTo="resultsLink"+ROW_INDEX_HERE ...
...
      <rich:modalPanel id="resultsModalPanel" + ROW_INDEX_HERE ...
...
             <h:graphicImage ... id="resultsModelPanelHideLink" + ROW_INDEX_HERE />
             <rich:componentControl for="resultsModalPanel" + ROW_INDEX_HERE attachTo="resultsModelPanelHideLink" + ROW_INDEX_HERE ...

Because we have the potential to needing to show a "Failure" link in multiple rows in the data table, we need a way to share a single model panel. I'm sure it can be done, I just haven't looked into how to refactor the example code shown in this jira issue to do it.

mazz, take a look at the events history page.  i did something where i used a single modal to display the details of the click event on the event row.

also, need to make sure that the scrollbars show appropriate for clipped content:

use style="overflow: auto;" on the modalPanel itself
use style="white-space: pre-wrap; font-family: Courier New, monospace;"

see rev3554 for a template of this.

This bug was previously known as http://jira.rhq-project.org/browse/RHQ-665
Imported an attachment (id=368876)
Imported an attachment (id=368877)
Imported an attachment (id=368878)
This bug is related to RHQ-610

*** Bug 535955 has been marked as a duplicate of this bug. ***

*** Bug 536239 has been marked as a duplicate of this bug. ***

mass add of key word FutureFeature to help track

closing per gwt effort