Bug 536920 - [abrt] crash detected in fontforge-20090923-1.fc12
Summary: [abrt] crash detected in fontforge-20090923-1.fc12
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: 0xFFFF
Version: 12
Hardware: x86_64
OS: Linux
low
medium
Target Milestone: ---
Assignee: Kevin Fenzi
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: abrt_hash:b3e2ab72c0df6624350588b46b7...
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-11-11 19:28 UTC by Nicolas Mailhot
Modified: 2010-07-18 18:04 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-07-18 18:04:47 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
File: backtrace (19.64 KB, text/plain)
2009-11-11 19:28 UTC, Nicolas Mailhot
no flags Details
Smallest subset of original font that produces crash (2.09 KB, text/plain)
2010-07-12 18:13 UTC, Paul Flo Williams
no flags Details
Correct LayerUnAllSplines() when refs have nil splinesets (779 bytes, patch)
2010-07-14 11:47 UTC, Paul Flo Williams
no flags Details | Diff

Description Nicolas Mailhot 2009-11-11 19:28:00 UTC
abrt detected a crash.

Attached file: backtrace
cmdline: /usr/bin/fontforge -lang=ff /usr/bin/fontlint usr/share/poker3d/data/neurpoli.ttf
component: fontforge
executable: /usr/bin/fontforge
kernel: 2.6.31.5-122.fc12.x86_64
package: fontforge-20090923-1.fc12
rating: 3
reason: Process was terminated by signal 11

Comment 1 Nicolas Mailhot 2009-11-11 19:28:03 UTC
Created attachment 369093 [details]
File: backtrace

Comment 2 Kevin Fenzi 2010-01-09 04:17:37 UTC
reported upstream.

Comment 3 Kevin Fenzi 2010-07-04 19:05:09 UTC
I'm not sure if this one was fixed or not. 

Do you see it with current rawhide fontforge?

Comment 4 Paul Flo Williams 2010-07-12 17:04:16 UTC
This still segfaults with the scratch build you made on 2010-07-04:

http://koji.fedoraproject.org/koji/taskinfo?taskID=2294313

This is the build with sources from 2010-05-01.

It also crashes with current CVS, sources from 2010-06-25.

Comment 5 Paul Flo Williams 2010-07-12 18:13:26 UTC
Created attachment 431233 [details]
Smallest subset of original font that produces crash

I have cut the original font down to the smallest subset that reproduces the original crash, and attached it here.

Validation crashes on the ellipsis character, which is made by reference to two other characters, full stop and space. The references to space are pointless, as it has no outlines.

I am about to send a bug report to the upstream mailing list with this information.

Comment 6 Kevin Fenzi 2010-07-13 04:27:19 UTC
Thanks Paul. :) Hopefully upstream will find a fix.

Comment 7 Paul Flo Williams 2010-07-14 11:47:05 UTC
Created attachment 431739 [details]
Correct LayerUnAllSplines() when refs have nil splinesets

When validation is performed, the set of splines for each character, including those used by reference (diacritics, for example), are "flattened" to one set by LayerAllSplines(). LayerUnAllSplines() is supposed to perform the reverse transformation, but fails if any references have nil splinesets.

This patch applies to 20090923, for the benefit of F13 and rawhide. It will be supplied upstream for CVS head with more information this evening.

Local testing:

[paul@palant x86_64]$ fontlint /usr/share/poker3d/data/neurpoli.ttf 
Copyright (c) 2000-2009 by George Williams.
 Executable based on sources from 23:48 GMT 23-Sep-2009.
 Library based on sources from 17:32 GMT 14-Sep-2009.
The following table(s) in the font have been ignored by FontForge
  Ignoring 'LTSH' linear threshold table
  Ignoring 'VDMX' vertical device metrics table
  Ignoring 'hdmx' horizontal device metrics table
The glyph named periodcentered is mapped to U+2219.
  But its name indicates it should be mapped to U+00B7.
The glyph named Delta is mapped to U+2206.
  But its name indicates it should be mapped to U+0394.
Validation Neuropolitical ...Failed
  Self Intersecting Glyph
  Missing Points at Extrema

Comment 8 Kevin Fenzi 2010-07-16 20:34:23 UTC
I can go ahead and add this patch in rawhide... or did we need to backport it to the f12/f13 versions? 

Typically we don't upgrade fontforge in a stable release to avoid any regressions with fonts already built with it. 

Thoughts?

Comment 9 Paul Flo Williams 2010-07-16 21:43:25 UTC
I'd patch it in rawhide. The chances of this occurring with any other font are extremely slim (and I ran fontlint on 30000 of them yesterday).

If bug 615347 is accepted, this font won't be in Fedora for long anyway ;-)

Comment 10 Kevin Fenzi 2010-07-16 22:56:37 UTC
ok. Built for rawhide: 
http://koji.fedoraproject.org/koji/taskinfo?taskID=2324995

Shall we close this bug now?

Comment 11 Paul Flo Williams 2010-07-18 11:31:39 UTC
(In reply to comment #10)
> 
> Shall we close this bug now?    

I vote yes.


Note You need to log in before you can comment on or make changes to this bug.