Description of problem: This is a list of issues for the gfs2 init script when compared with the criteria in https://fedoraproject.org/wiki/Packaging/SysVInitScript Version-Release number of selected component (if applicable): gfs2-utils-3.0.4-1.fc12.i686 * force-reload is implemented, but not included in the usage statement * required action condrestart (and try-restart) are missing * wrong exit status when gfs2 is configured but not mounted, should be 3 [root@morph-04 init.d]# service gfs2 status Configured GFS2 mountpoints: /mnt/ctdb [root@morph-04 init.d]# echo $? 0 * leftover lock file is not detected, exit status should be 2 [root@morph-04 init.d]# touch /var/lock/subsys/gfs2 [root@morph-04 init.d]# service gfs2 status Configured GFS2 mountpoints: /mnt/ctdb [root@morph-04 init.d]# echo $? 0 * wrong exit status when no action is given, should be 2 [root@morph-04 init.d]# service gfs2 Usage: /etc/init.d/gfs2 {start|stop|restart|reload|status} [root@morph-04 init.d]# echo $? 1 * wrong exit status when invalid action is given, should be 2 [root@morph-04 init.d]# service gfs2 fubar Usage: /etc/init.d/gfs2 {start|stop|restart|reload|status} [root@morph-04 init.d]# echo $? 1 *
This bug appears to have been reported against 'rawhide' during the Fedora 12 development cycle. Changing version to '12'. More information and reason for this action is here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping
reassigning to the right component
Created attachment 388528 [details] proposed patch
Created attachment 388529 [details] proposed patch
http://git.fedorahosted.org/git/?p=cluster.git;a=commitdiff;h=6d2ce78aa8124a1586ed950bb7627f89f0f9d2b8