Spec URL: http://people.redhat.com/~pmachata/mpc-complex/mpc-complex.spec SRPM URL: http://people.redhat.com/~pmachata/mpc-complex/mpc-complex-0.8-1.fc11.src.rpm Description: MPC is a C library for the arithmetic of complex numbers with arbitrarily high precision and correct rounding of the result. It is built upon and follows the same principles as Mpfr.
Note that the upstream distribution is called "mpc", but there already is a package called "mpc" in the distribution ("Command-line client for MPD"). I called the library mpc-complex, but I'm open to other ideas.
$ rpmlint ../RPMS/x86_64/mpc-complex-* ../SRPMS/mpc-complex-* mpc-complex.spec 4 packages and 1 specfiles checked; 0 errors, 0 warnings.
Forgot to note, the reason I'm packaging this is that GCC 4.5 will likely require it.
Some comments on your spec: * BuildRequires: gmp mpfr .. This doesn't make sense. AFAIS, you either want BR: gmp-devel mpfr-devel or remove both of these BRs. Probably related to this: The package doesn't build in mock (fedora-12-x86_64): ... configure: error: libgmp not found or uses a different ABI. error: Bad exit status from /var/tmp/rpm-tmp.DIaEc2 (%build) Bad exit status from /var/tmp/rpm-tmp.DIaEc2 (%build) * You are packaging the infos into the "main" package. This package however is a pure library package, i.e. all the docs it contains are only of interest to developers => I recommend you to move the infos into the *-devel subpackage.
Further findings: * package name: Why did you choose "mpc-complex"? Of cause, to avoid a package name conflict with the "other mpc". However, to me, you naming appears to be an "arkward" choice. I would prefer using libmpc or similar. * Why are you trying to build *.ps docs? a) It's broken (missing deps) b) I don't see any benefits in doing so.
New files: http://people.redhat.com/~pmachata/libmpc/libmpc.spec http://people.redhat.com/~pmachata/libmpc/libmpc-0.8-2.fc11.src.rpm - Renamed the package to libmpc, which is indeed a much better name. - Fixed BRs. - Infos moved to -devel. - Peeked into the postscript and it's indeed not that interesting, it's all in the info pages. So I dropped it. - Actually tried to build in mock this time, and it worked.
(In reply to comment #6) Much better, now ;) Launching formal review: Mostly OK, except: * (MUSTFIX) /usr/include/mpc.h includes "mpfr.h" and "gmp.h", i.e. there is a hard dependency between *-devel and mpfr-devel+gmp-devel => *-devel must Require: mpfr-devel gmp-devel * (SHOULD) What is the reason for you to explicitly pass --entry ... while installing the infos? Except of cases, when the infos are broken, such a step should not be necessary and thus be avoided.
New files: http://people.redhat.com/~pmachata/libmpc/libmpc.spec http://people.redhat.com/~pmachata/libmpc/libmpc-0.8-3.fc11.src.rpm - Require mpfr-devel, gmp-devel in -devel subpackage - Don't pass --entry to install-info (checked that it installs the info entry correctly)
Thanks for your quick responses. Package is APPROVED. Additional, private, personal request: Please also branch for FC11 and FC12. I would personally need this package on FC11 and FC12, very soon. TIA.
New Package CVS Request ======================= Package Name: libmpc Short Description: C library for multiple precision complex arithmetic Owners: pmachata Branches: F-11 F-12 InitialCC:
CVS done.
Built and requested an update for F11 and F12. Thanks for cooperation!
Package Change Request ====================== Package Name: libmpc New Branches: EL-6 Owners: pmachata InitialCC:
CVS done (by process-cvs-requests.py).