Bug 537152 - uninitialized variable "method" in fence_ipmilan can cause breakage when trying to fence a node without explicitly specifying a value
Summary: uninitialized variable "method" in fence_ipmilan can cause breakage when tryi...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: cman
Version: 5.4
Hardware: All
OS: Linux
urgent
high
Target Milestone: rc
: ---
Assignee: Jan Friesse
QA Contact: Cluster QE
URL:
Whiteboard:
Depends On: 532138
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-11-12 16:53 UTC by Benjamin Kahn
Modified: 2016-04-26 13:43 UTC (History)
7 users (show)

Fixed In Version: cman-2.0.115-1.el5_4.9.src.rpm
Doc Type: Bug Fix
Doc Text:
Cause: ======= User wants use fence_ipmilan agent, without specifying -M parameter. Consequence: ============ Because memory is not properly initialized, agent called without -M parameter can: - Use onoff method as usual and expected. OR - Fail with message "method, if included, muse be 'onoff', 'cycle'". OR - use cycle method Fix: ==== Correctly initialize -M parameters memory Result: ======= Without using -M, default action is now correctly always onoff.
Clone Of:
Environment:
Last Closed: 2009-12-01 07:49:50 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Patch from 5.5 (728 bytes, patch)
2009-11-19 11:00 UTC, Jan Friesse
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2009:1622 0 normal SHIPPED_LIVE cman bug-fix update 2009-12-01 07:49:32 UTC

Description Benjamin Kahn 2009-11-12 16:53:42 UTC
This bug has been copied from bug #532138 and has been proposed
to be backported to 5.4 z-stream (EUS).

Comment 3 Jan Friesse 2009-11-19 11:00:01 UTC
Created attachment 370312 [details]
Patch from 5.5

Same patch used as in https://bugzilla.redhat.com/show_bug.cgi?id=532138 case

Comment 4 Jan Friesse 2009-11-19 11:00:43 UTC
Release note added. If any revisions are required, please set the 
"requires_release_notes" flag to "?" and edit the "Release Notes" field accordingly.
All revisions will be proofread by the Engineering Content Services team.

New Contents:
Cause:
=======
User wants use fence_ipmilan agent, without specifying -M parameter.

Consequence:
============
Because memory is not properly initialized, agent called without -M parameter can:
- Use onoff method as usual and expected. OR
- Fail with message "method, if included, muse be 'onoff', 'cycle'". OR
- use cycle method

Fix:
====
Correctly initialize -M parameters memory

Result:
=======
Without using -M, default action is now correctly always onoff.

Comment 5 Jan Friesse 2009-11-19 11:18:59 UTC
Committed in RHEL54 GIT as patch with SHA1: a8d2b47fe7aca0bd061e86fde33be2d28cdef956

Comment 8 errata-xmlrpc 2009-12-01 07:49:50 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2009-1622.html


Note You need to log in before you can comment on or make changes to this bug.