Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
For bugs related to Red Hat Enterprise Linux 5 product line. The current stable release is 5.10. For Red Hat Enterprise Linux 6 and above, please visit Red Hat JIRA https://issues.redhat.com/secure/CreateIssue!default.jspa?pid=12332745 to report new issues.

Bug 537152

Summary: uninitialized variable "method" in fence_ipmilan can cause breakage when trying to fence a node without explicitly specifying a value
Product: Red Hat Enterprise Linux 5 Reporter: Benjamin Kahn <bkahn>
Component: cmanAssignee: Jan Friesse <jfriesse>
Status: CLOSED ERRATA QA Contact: Cluster QE <mspqa-list>
Severity: high Docs Contact:
Priority: urgent    
Version: 5.4CC: ccaulfie, cluster-maint, djansa, edamato, jruemker, pm-eus, rlerch
Target Milestone: rcKeywords: ZStream
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: cman-2.0.115-1.el5_4.9.src.rpm Doc Type: Bug Fix
Doc Text:
Cause: ======= User wants use fence_ipmilan agent, without specifying -M parameter. Consequence: ============ Because memory is not properly initialized, agent called without -M parameter can: - Use onoff method as usual and expected. OR - Fail with message "method, if included, muse be 'onoff', 'cycle'". OR - use cycle method Fix: ==== Correctly initialize -M parameters memory Result: ======= Without using -M, default action is now correctly always onoff.
 Story Points: ---
Clone Of: Environment:
Last Closed: 2009-12-01 07:49:50 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 532138    
Bug Blocks:    
Attachments:
Description Flags
Patch from 5.5 none

Description Benjamin Kahn 2009-11-12 16:53:42 UTC 
This bug has been copied from bug #532138 and has been proposed
to be backported to 5.4 z-stream (EUS).
Comment 3 Jan Friesse 2009-11-19 11:00:01 UTC 
Created attachment 370312 [details]
Patch from 5.5

Same patch used as in https://bugzilla.redhat.com/show_bug.cgi?id=532138 case
Comment 4 Jan Friesse 2009-11-19 11:00:43 UTC 
Release note added. If any revisions are required, please set the 
"requires_release_notes" flag to "?" and edit the "Release Notes" field accordingly.
All revisions will be proofread by the Engineering Content Services team.

New Contents:
Cause:
=======
User wants use fence_ipmilan agent, without specifying -M parameter.

Consequence:
============
Because memory is not properly initialized, agent called without -M parameter can:
- Use onoff method as usual and expected. OR
- Fail with message "method, if included, muse be 'onoff', 'cycle'". OR
- use cycle method

Fix:
====
Correctly initialize -M parameters memory

Result:
=======
Without using -M, default action is now correctly always onoff.
Comment 5 Jan Friesse 2009-11-19 11:18:59 UTC 
Committed in RHEL54 GIT as patch with SHA1: a8d2b47fe7aca0bd061e86fde33be2d28cdef956
Comment 8 errata-xmlrpc 2009-12-01 07:49:50 UTC 
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2009-1622.html