Description of problem: In xemacs ediff, after a change is copied from buffer B to buffer A, 'ra' should revert the change in buffer A. Instead, I got this error Nothing saved for diff 1 in buffer nil in mini-buffer line, and the region is not restored. Also in diff, ctrl-V should scroll both buffers A,B down a page. But in my F11 it scrolls *up* instead of *down*. Version-Release number of selected component (if applicable): xemacs-packages-extra-20090217-4.fc11.noarch How reproducible: always Steps to Reproduce: 1. run xemacs, either GUI mode or text mode 2. M-X ediff-buffers, and select two buffers that are different in only a few lines. 3. 'n' in ediff control panel. 4. ctrl-V to scroll down both buffers A,B a page. 5. 'b' to bring the changes from buffer B to buffer A. 6. 'ra' to revert the change in buffer A. Actual results: In step 4, buffers A,B should scroll *up*. In step 6, buffer A did not revert its content; got error msg Nothing saved for diff 1 in buffer nil Expected results: In step 4, buffers A,B should scroll *down*. In step 6, buffer A should revert its content. Additional info:
I can reproduce this. I have asked the ediff maintainer for ideas on what might be wrong. Stand by...
Jerry, Thanks for quick action!
xemacs-packages-extra-20090217-6.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/xemacs-packages-extra-20090217-6.fc12
xemacs-packages-extra-20090217-5.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/xemacs-packages-extra-20090217-5.fc11
xemacs-packages-extra-20090217-5.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update xemacs-packages-extra'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-12567
xemacs-packages-extra-20090217-6.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update xemacs-packages-extra'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2009-12596
Jeff, Thanks! I tried xemacs-packages-extra-20090217-5.fc11.noarch and it did fix the original issues: 1. ctrl-V scrolls down both buffers now. 2. revert works now But now Alt-V also scrolls both buffers down (should be up). Could you check if this is the case for you? Should I open a new bug for Alt-V, or should we keep this bug open? To me -5.fc11 is good for release, because it fixes the revert function, which is more important (to me) than Alt-V being broken.
Let's keep this bug open. We'll make it the "broken ediff keybindings" bug. :-) Let me go talk to the ediff maintainer again. The previous problem was that he had done some development work on Emacs, then synched his changes over to XEmacs, but overlooked a handful of Emacs-specific functions in the code. I'm guessing there's yet another Emacs-specific function in the code path exercised by Alt-V. If it looks like it might take more than a couple of days to get a fix, I won't delay releasing the updates in comment 5 and comment 6.
By the way, I notice that 'V' scrolls up, so at least there's a workaround until we can get this next one fixed. It involves modifying muscle memory, though. :-)
I see the problem. Try evaluating this in *scratch* after ediff is loaded and see if it works for you. (defun ediff-event-key (event-or-key) (if (featurep 'xemacs) (if (eventp event-or-key) (event-character event-or-key t t) event-or-key) event-or-key))
Re: Comment #10 I tried it, but it did not help in my case; Alt-v still scrolls down (should be up). Did I miss anything? I pasted the lisp code in Comment #10, and did "M-x eval-current-buffer". Then Alt-v still does the wrong thing. Re: Comment #9 Yes, the work around (Shift-V) works well. Thanks! Re: Comment #8 I understand; after some major changes, this happens from time to time. Thanks for your effort to make xemacs (and ediff) better!
Gah, typo. :-( You have to use ediff once first, otherwise it will load the original (bad) definition again once you start ediff. After running ediff once, paste the following defun into the *scratch* buffer. Put the cursor just after the closing parenthesis and press C-j. Then run ediff again and M-v should work. (defun ediff-event-key (event-or-key) (if (and (featurep 'xemacs) (eventp event-or-key)) (event-to-character event-or-key t t) event-or-key))
Re: Comment #12 Yes, that works well! I'll wait till we have the proper fix; in the mean time I can live with Comment #9 (Shift-V).
xemacs-packages-extra-20090217-7.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update xemacs-packages-extra'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2009-12596
xemacs-packages-extra-20090217-6.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update xemacs-packages-extra'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-12567
I tested xemacs-packages-extra-20090217-6.fc11.noarch It worked as expected; v/ctrl-V scrolls down; shift-V/alt-V scrolls up; rX reverts the changes properly. So I think this fix is good to go, and we can close this bug. Jerry, Thanks for tracking down this issue!
xemacs-packages-extra-20090217-6.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
xemacs-packages-extra-20090217-7.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.