Description of problem: "No changes were made to the configuration, so no update request has been sent to the Agent." message is displayed if you edit a config in structured mode Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. Login to RHQ server with agent running 2. Select the Structured & Raw server 3. Click on the configure tab 4. Click on change properties 5. change a value and click save Actual results: "No changes were made to the configuration, so no update request has been sent to the Agent." message is displayed. Expected results: To be able to commit the structured config change Additional info:
Even the existing plugins fails to commmit the edits from structured config. It displays a message "Maps updated".
Added this code to ConfigurationManagerBean + void dumpProperties(Configuration c) { + for (String key : c.getAllProperties().keySet()) { + log.error("property " + key + " = " + c.get(key)); + } + } @Nullable public ResourceConfigurationUpdate updateResourceConfiguration(Subject subject, int resourceId, @XmlJavaTypeAdapter(ConfigurationAdapter.class) Configuration newConfiguration) throws ResourceNotFoundException { // must do this in a separate transaction so it is committed prior to sending the agent request // (consider synchronizing to avoid the condition where someone calls this method twice quickly // in two different txs which would put two updates in INPROGRESS and cause havoc) ResourceConfigurationUpdate newUpdate; + dumpProperties(newConfiguration); // here we call ourself, but we do so via the EJB interface so we pick up the REQUIRES_NEW semantics // this can return null if newConfiguration is not actually different. newUpdate = configurationManager.persistNewResourceConfigurationUpdateHistory(subject, resourceId, newConfiguration, ConfigurationUpdateStatus.INPROGRESS, subject.getName(), false); This shows the values that were changed in the UI being passed down correctly.
Problem was with how the configuration object was shared between raw and structured, which didn't match the pre-existing code. Code has been pushed to origin/raw-config on Fedora Hosted and confirmed to work on my local machine. We should see the hudson test failures stop off in a build shortly.
Fails_qa tried to edit hosts config the message said "Maps Updated" And the hosts config UI displayed the edited value. but when I navigated to the history page there was no record of the new commit. Also checked in the hosts file of the managed platform and it did not reflect the change. But the change stayed in the memory until I logged out of the rhq server.
I think this is user error on my part. moving to fixed. Will reopen if it fails again.
I am changing the status to on_qa to test after integration with master.
This has been resolved. was able to make changes & save changes to the /etc/hosts file. verified in master http://10.16.120.159:7080/
Mass-closure of verified bugs against JON.