Bug 538407 - PCI AER code introduced a compile problem in powerpc
Summary: PCI AER code introduced a compile problem in powerpc
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: kernel
Version: 5.5
Hardware: All
OS: Linux
low
medium
Target Milestone: rc
: ---
Assignee: Prarit Bhargava
QA Contact: Red Hat Kernel QE team
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-11-18 13:47 UTC by Prarit Bhargava
Modified: 2010-03-30 07:45 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-03-30 07:45:51 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2010:0178 0 normal SHIPPED_LIVE Important: Red Hat Enterprise Linux 5.5 kernel security and bug fix update 2010-03-29 12:18:21 UTC

Description Prarit Bhargava 2009-11-18 13:47:41 UTC
Description of problem:


arch/powerpc/platforms/pseries/eeh_driver.c: In function ‘handle_eeh_events’:
arch/powerpc/platforms/pseries/eeh_driver.c:404: warning: passing argument 2 of ‘pci_walk_bus’ from incompatible pointer type
arch/powerpc/platforms/pseries/eeh_driver.c:442: warning: passing argument 2 of ‘pci_walk_bus’ from incompatible pointer type
arch/powerpc/platforms/pseries/eeh_driver.c:472: warning: passing argument 2 of ‘pci_walk_bus’ from incompatible pointer type
arch/powerpc/platforms/pseries/eeh_driver.c:483: warning: passing argument 2 of ‘pci_walk_bus’ from incompatible pointer type
arch/powerpc/platforms/pseries/eeh_driver.c:512: warning: passing argument 2 of ‘pci_walk_bus’ from incompatible pointer type
  CC      arch/powerpc/kernel/of_device.o
  CC      ipc/sem.o
  CC      kernel/sysctl.o
  CC      arch/powerpc/platforms/pseries/eeh_event.o
  CC      kernel/capability.o
arch/powerpc/platforms/pseries/eeh_event.c:41: warning: initialization from incompatible pointer type
  CC      arch/powerpc/kernel/of_platform.o
  CC      fs/block_dev.o
  CC      arch/powerpc/platforms/pseries/hv

173.el5: compiles clean

CC      arch/powerpc/platforms/pseries/eeh_driver.o
LD      arch/powerpc/platforms/pseries/built-in.o
LD      arch/powerpc/platforms/built-in.o

Version-Release number of selected component (if applicable): 2.6.18-174.el5


How reproducible: 100%


Additional info: I think what happened is that my patch-compile utility got a little bit out of whack with the compiles I was doing ... and this totally got missed.

:(

P.

Comment 1 Prarit Bhargava 2009-11-18 13:48:24 UTC
RHEL5 commit b421ee2a793b891ce195c979fd329e3d4e30d510 explicitly changes these functions from void to int.

That's wrong.

P.

Comment 2 RHEL Program Management 2009-11-18 13:52:07 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 3 Prarit Bhargava 2009-11-18 14:01:38 UTC
I don't think this will cause any functional issues -- the int return will be
ignored.  But I'm patching in order to fix the compile ...

P.

Comment 4 Don Zickus 2009-11-23 15:34:19 UTC
in kernel-2.6.18-175.el5
You can download this test kernel from http://people.redhat.com/dzickus/el5

Please do NOT transition this bugzilla state to VERIFIED until our QE team
has sent specific instructions indicating when to do so.  However feel free
to provide a comment indicating that this fix has been verified.

Comment 7 Petr Beňas 2010-03-24 15:55:17 UTC
I've tested this after release_pending...

kernel-2.6.18-174.el5 compiling:
  CC      arch/powerpc/platforms/pseries/eeh_driver.o
arch/powerpc/platforms/pseries/eeh_driver.c: In function ‘handle_eeh_events’:
arch/powerpc/platforms/pseries/eeh_driver.c:404: warning: passing argument 2 of ‘pci_walk_bus’ from incompatible pointer type
arch/powerpc/platforms/pseries/eeh_driver.c:442: warning: passing argument 2 of ‘pci_walk_bus’ from incompatible pointer type
arch/powerpc/platforms/pseries/eeh_driver.c:472: warning: passing argument 2 of ‘pci_walk_bus’ from incompatible pointer type
arch/powerpc/platforms/pseries/eeh_driver.c:483: warning: passing argument 2 of ‘pci_walk_bus’ from incompatible pointer type
arch/powerpc/platforms/pseries/eeh_driver.c:512: warning: passing argument 2 of ‘pci_walk_bus’ from incompatible pointer type
  CC      arch/powerpc/platforms/pseries/eeh_event.o
arch/powerpc/platforms/pseries/eeh_event.c:41: warning: initialization from incompatible pointer type
  CC      arch/powerpc/platforms/pseries/hvconsole.o
  LD      arch/powerpc/platforms/pseries/built-in.o
  CC [M]  arch/powerpc/platforms/pseries/hvcserver.o
  LD      arch/powerpc/platforms/built-in.o

kernel-2.6.18-175.el5 compiling:
  CC      arch/powerpc/platforms/pseries/eeh_driver.o
  CC      arch/powerpc/platforms/pseries/eeh_event.o
arch/powerpc/platforms/pseries/eeh_event.c:41: warning: initialization from incompatible pointer type
  CC      arch/powerpc/platforms/pseries/hvconsole.o

Comment 8 errata-xmlrpc 2010-03-30 07:45:51 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2010-0178.html


Note You need to log in before you can comment on or make changes to this bug.