Spec URL: http://mmaslano.fedorapeople.org/review/perl-Devel-Refactor.spec SRPM URL: http://mmaslano.fedorapeople.org/review/perl-Devel-Refactor-0.05-1.fc12.src.rpm Description: The Devel::Refactor module is for code refactoring.
Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1815776 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 6d94f77e2a0a2841784fd453bf0f58605c481761 Devel-Refactor-0.05.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=3, Tests=83, 0 wallclock secs ( 0.03 usr 0.01 sys + 0.19 cusr 0.00 csys = 0.23 CPU) + Package perl-Devel-Refactor-0.05-1.fc13.noarch => Provides: perl(Devel::Refactor) = 0.05 Requires: perl(Cwd) perl(Exporter) perl(File::Basename) perl(strict) perl(warnings) + Not a GUI application APPROVED.
New Package CVS Request ======================= Package Name: perl-Devel-Refactor Short Description: Perl extension for refactoring Perl code Owners: mmaslano Branches: devel InitialCC: perl-sig
CVS done.