SPEC: http://pbrobinson.fedorapeople.org/libmx.spec SRPM: http://pbrobinson.fedorapeople.org/libmx-0.1.1-1.fc12.src.rpm %description The Moblin User Experience is a GUI toolkit, using Clutter and is optimised for Moblin. It consists of various classes useful for building UIs such as Buttons, Tooltips, Scrollbars and others. It also supports styling through CSS stylesheets. NOTE: the upstream name for this package is mx but there is a conflicting python package called mx already. koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1814556
New upstream SRPM: http://pbrobinson.fedorapeople.org/libmx-0.1.2-1.fc12.src.rpm
New upstream SRPM: http://pbrobinson.fedorapeople.org/libmx-0.2.0-1.fc12.src.rpm koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1842627
New upstream 0.3.0 release. SRPM: http://pbrobinson.fedorapeople.org/libmx-0.3.0-1.fc12.src.rpm koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1870119
Given the existence of the mx/mx-devel packages, a little more description in the -devel packages might help
There is also another project called mx/libmx which seems to be older and still be maintained: http://www.lostsidedead.com/mx/ I suggest to use moblin-mx to avoid potential future conflicts, but this might be worth discussion on fedora-devel.
just had a quick look: * I think that %{_datadir}/gtk-doc/html/mx needs to be tagged with %doc. * Also please span the description to 80 columns as much as possible. * Source0 seems wrong.
(In reply to comment #4) > Given the existence of the mx/mx-devel packages, a little more description in > the -devel packages might help I'm going to shortly improve all the descriptions. It looks like the gnome-shell people are going to be making use of this so I want to remove all mention of Moblin in the description as it looks like its going to be used in gnome-shell (this library will replace nbtk for Moblin 2.2) and gnome-shell pulls in a chunk of nbtk.
> just had a quick look: > * I think that %{_datadir}/gtk-doc/html/mx needs to be tagged with %doc. I have been told that gtk-doc will automatically get tagged as docs due to the %{_datadir}/gtk-doc dir being tagged as %doc. > * Also please span the description to 80 columns as much as possible. Will update when I update the description > * Source0 seems wrong. In the rush I didn't update the URL. Will fix.
Updated. SPEC: http://pbrobinson.fedorapeople.org/libmx.spec SRPM: http://pbrobinson.fedorapeople.org/libmx-0.3.0-2.fc12.src.rpm
I'm going to take a look at this one.
[ OK ] specfiles match: 5b84e5e23a3ed18216bb0c4e8d8961db [ OK ] source files match upstream: 916694e534ae745d3a809c4634b6696f [ OK ] package meets naming and versioning guidelines. [ OK ] spec is properly named, cleanly written, and uses macros consistently. [ OK ] dist tag is present. [ OK ] build root is correct. [ OK ] license field matches the actual license. [ OK ] license is open source-compatible. [ OK ] license text included in package. [ OK ] latest version is being packaged. [ OK ] BuildRequires are proper. [ OK ] compiler flags are appropriate. [ OK ] %clean is present. [ OK ] package builds in mock: http://koji.fedoraproject.org/koji/taskinfo?taskID=1902982 [ OK ] package installs properly. [ OK ] debuginfo package looks complete. [ OK ] rpmlint is silent: libmx-devel.i686: W: no-documentation [ OK ] final provides and requires are sane [ NA ] %check is present and all tests pass [ OK ] no shared libraries are added to the regular linker search paths. [ NA ] owns the directories it creates. [ OK ] doesn't own any directories it shouldn't. [ OK ] no duplicates in %files. [ OK ] file permissions are appropriate. [ NA ] scriptlets match those on ScriptletSnippets page. [ OK ] code, not content. [ OK ] docs subpackage is appropriately created [ OK ] %docs are not necessary for the proper functioning of the package. [ OK ] headers go into devel package. [ OK ] pkgconfig files are in devel package. [ OK ] no libtool .la droppings. [ NA ] desktop files valid and installed properly. Looks like you're good to go here. The rpmlint warning is a non-issue, since the devel package pulls the main package in anyway. So this is APPROVED.
New Package CVS Request ======================= Package Name: libmx Short Description: A clutter widget toolkit Owners: pbrobinson Branches: F-12 InitialCC:
cvs done.
Built and in rawhide. Thanks for the review and feedback!