Spec URL: http://thomasj.fedorapeople.org/reviews/kde-partitionmanager.spec SRPM URL: http://thomasj.fedorapeople.org/reviews/kde-partitionmanager-1.0.0-1.fc11.src.rpm Description: KDE Partition Manager is a utility program to help you manage the disk devices, partitions and file systems on your computer. It allows you to easily create, copy, move, delete, resize without losing data, backup and restore partitions. KDE Partition Manager supports a large number of file systems, including ext2/3/4, reiserfs, NTFS, FAT16/32, jfs, xfs and more. It makes use of external programs to get its job done, so you might have to install additional software (preferably packages from your distribution) to make use of all features and get full support for all file systems. http://koji.fedoraproject.org/koji/taskinfo?taskID=1814928 [thomas@tusdell SPECS]$ rpmlint kde-partitionmanager.spec ../SRPMS/kde-partitionmanager-1.0.0-1.fc11.src.rpm ../RPMS/x86_64/kde-partitionmanager-* kde-partitionmanager.x86_64: E: invalid-soname /usr/lib64/libpartitionmanagerprivate.so libpartitionmanagerprivate.so 3 packages and 1 specfiles checked; 1 errors, 0 warnings. shlib error is there.
Good: + Basename of the SPEC file matches with package name + Package name fullfill naming guidelines + Package has proper BuildRoot defintion + Consitently usage of rpm macros + License tag declared GPLv2+ as a valid OSS license + Copyright notes in source files matches with declaration of license tag + Package contains verbatin copy of the license text + URL tags shows on proper project homepage + Could download upstream sources via spectool -g + Packaged upstream tar ball matches with upstream (md5sum: 07046e0c61ca3f06129580ffd7f9c66e) + Package has no subpackages + Rpmlint is silent on source package + Rpmlint is silent on debuginfo package + Debuginfo files contains source files + buildroot will be cleaned at the beginning of %clean and %install + Package has small %doc stanza, so no separate doc subpackage in required. + Local build works fine + Build is SMP clean + Local install and uninstall of the package works fine + Start of the application works without crash + Scratch build on koji works properly + Files stanza has proper default permisions + Files stanza has no duplicate entries + All fires and dirs are owned by the package + No files or dirs belong to another package + Package has proper Changelog stanza Bad - Rpmlint complaints on binary package: $ rpmlint kde-partitionmanager-1.0.0-1.fc11.x86_64.rpm kde-partitionmanager.x86_64: E: invalid-soname /usr/lib64/libpartitionmanagerprivate.so libpartitionmanagerprivate.so 1 packages and 0 specfiles checked; 1 errors, 0 warnings. Please contact upstream author to fix it. - Please mof the desktop-file-validate command to the %install stanza - qt4-devel is not required as a BR, because kdelibs4-devel requires qt4-devel
Thanks for doing the review. (In reply to comment #1) > Bad > - Rpmlint complaints on binary package: > $ rpmlint kde-partitionmanager-1.0.0-1.fc11.x86_64.rpm > kde-partitionmanager.x86_64: E: invalid-soname > /usr/lib64/libpartitionmanagerprivate.so libpartitionmanagerprivate.so > 1 packages and 0 specfiles checked; 1 errors, 0 warnings. > Please contact upstream author to fix it. I asked about that rpmlint output in #fedora-kde before i upped this review request and got answers from rdieter and Kevin_Kofler that it's only a private lib. "It's perfectly normal for a KCM to be an unversioned .so, it's a plugin, not a library, it gets dlopened. Nothing else will use it." Any further thoughts on that? > - Please mof the desktop-file-validate command to the %install stanza Moved to %install > - qt4-devel is not required as a BR, because kdelibs4-devel requires > qt4-devel Removed the BR -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers
It may be nice, if you can upload the new release and post the URL to it as a comment in this bug.
(In reply to comment #3) > It may be nice, if you can upload the new release and post the URL to it as a > comment in this bug. Sure, sorry. Spec URL: http://thomasj.fedorapeople.org/reviews/kde-partitionmanager.spec SRPM URL: http://thomasj.fedorapeople.org/reviews/kde-partitionmanager-1.0.0-2.fc11.src.rpm http://koji.fedoraproject.org/koji/taskinfo?taskID=1816855 -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers
Good: + desktop-file-validate was moved to %install + BR qt4-devel was removed. *** APPROVED ***
Thank you for the review. New Package CVS Request ======================= Package Name: kde-partitionmanager Short Description: KDE Partition Manager Owners: thomasj Branches: F-11 F-12 InitialCC: -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers
CVS done.
kde-partitionmanager-1.0.0-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/kde-partitionmanager-1.0.0-2.fc12
kde-partitionmanager-1.0.0-2.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update kde-partitionmanager'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2009-11994
kde-partitionmanager-1.0.0-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
Thomas Janssen, do you plan push updates for Fedora 11 too?
Hello Pavel, yes, i push updates always for every supported Fedora the same time. kde-partitionmanager-1.0.0-2 is as well in Fedora 11 and rawhide :) -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers
Oh, thanks. It seams you just forgot point bug number when push update to it and message bout it does not appeared there. I do not seen in repository directly - my bad.