Spec URL: http://mtasaka.fedorapeople.org/Review_request/rubygem-marc/rubygem-marc.spec SRPM URL: http://mtasaka.fedorapeople.org/Review_request/rubygem-marc/rubygem-marc-0.3.0-1.fc.src.rpm Description: marc is a ruby library for reading and writing MAchine Readable Cataloging (MARC). More information about MARC can be found at <http://www.loc.gov/marc>. Koji scratch build For F-13: http://koji.fedoraproject.org/koji/taskinfo?taskID=1819759 For F-12: http://koji.fedoraproject.org/koji/taskinfo?taskID=1819760 Note that this srpm creates ruby-marc subpackage, which will replace ruby-marc rpm which is already available on Fedora: https://admin.fedoraproject.org/pkgdb/packages/name/ruby-marc
(First time reviewing) Initial notes for 0.3.0-1: * %prep: - Looks like gem is creating a .gem directory outside the BuildRoot. From the build.log: + gem install --local --install-dir ./usr/lib/ruby/gems/1.8 --force --rdoc -V /builddir/build/SOURCES/marc-0.3.0.gem Installing gem marc-0.3.0 Using local gem /builddir/.gem/ruby/1.8/cache/marc-0.3.0.gem adding mkdir -p .%{gemdir} prior to the gem install appears to correct it. * %package -n ruby-%{gemname} Summary - Summary is different from main rubygem- package.
Thank you for the review. (In reply to comment #1) > * %prep: > * %package -n ruby-%{gemname} Summary Both fixed. http://mtasaka.fedorapeople.org/Review_request/rubygem-marc/rubygem-marc-0.3.0-2.fc.src.rpm http://mtasaka.fedorapeople.org/Review_request/rubygem-marc/rubygem-marc.spec * Mon Nov 23 2009 Mamoru Tasaka <mtasaka.u-tokyo.ac.jp> - 0.3.0-2 - Fix Summary - Surely create .%%{gemdir} before installing gem file
-------------------------------------------------------- This package (rubygem-marc) is approved by mkent --------------------------------------------------------
Thank you! New Package CVS Request ======================= Package Name: rubygem-marc Short Description: Ruby library for MARC catalog Owners: mtasaka Branches: F-12 F-11 InitialCC: (nobody)
cvs done.
Rebuilt on all branches, submitted push requests on bodhi, closing. Thank you for reviewing this and CVS procedure.