Bug 539989 - Review Request: nettop - top-like program for network packets
Review Request: nettop - top-like program for network packets
Status: CLOSED NOTABUG
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Nobody's working on this, feel free to take it
Fedora Extras Quality Assurance
:
Depends On:
Blocks: FE-DEADREVIEW
  Show dependency treegraph
 
Reported: 2009-11-21 15:58 EST by Bernard Johnson
Modified: 2010-08-19 20:46 EDT (History)
6 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2010-08-19 20:46:10 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Bernard Johnson 2009-11-21 15:58:22 EST
Spec URL: http://fedorapeople.org/~bjohnson/nettop.spec
SRPM URL: http://fedorapeople.org/~bjohnson/nettop-0.2.3-1.fc12.src.rpm
Description: Nettop is a program which looks like top, but is for network packets.

$ rpmlint *rpm
nettop.src: W: summary-not-capitalized top-like program for network packets
nettop.x86_64: W: summary-not-capitalized top-like program for network packets
3 packages and 0 specfiles checked; 0 errors, 2 warnings.

These warning can be ignored because it is the proper capitalization for this program name, it just happens to be at the beginning of the line.
Comment 1 Susi Lehtola 2009-11-24 09:14:29 EST
Change the summary to "A top-like program for network packets" to fix the rpmlint warnings.
Comment 2 Susi Lehtola 2009-11-24 09:16:49 EST
Furthermore, add comments in the spec file as to why Source1-2 and Patch0-2 are needed. Also, please rename your patches to start with nettop-,  e.g.

 # Patch to fix compilation errors 
 Patch0:         nettop-compile.patch

This way build directories stay cleaner.
Comment 3 Susi Lehtola 2009-11-24 09:18:59 EST
And a few more comments: use %{version} in the Source0 line to ease up the maintaining of the spec file.

The upstream project server seems to be down, so a review cannot be performed at this stage.
Comment 4 Bernard Johnson 2009-11-24 20:33:36 EST
Spec URL: http://fedorapeople.org/~bjohnson/nettop.spec
SRPM URL: http://fedorapeople.org/~bjohnson/nettop-0.2.3-2.fc12.src.rpm

* Tue Nov 24 2009 Bernard Johnson <bjohnson@symetrix.com> - 0.2.3-2
- begin summary line with 'A'
- source0 by name/version macros
- better comments regarding additional sources & patches
- source1/2 were reversed

$ rpmlint *rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.
Comment 5 Pavel Alexeev 2010-01-02 11:10:59 EST
Offsite http://srparish.net/scripts/ seams down.

Meantime where links to upstream bugreports for each patches?
https://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment
Comment 6 Bernard Johnson 2010-01-11 17:57:13 EST
I sent the author an email asking about the website.  I will let you know when I get a response.
Comment 7 Rafael Aquini 2010-08-09 22:33:17 EDT
PING

Since it's been more than six months with no progress; I guess this bug should be closed soon if there is no response, shouldn't it?
Comment 8 Rafael Aquini 2010-08-19 20:46:10 EDT
Due to the lack of response this review is now considered as stalled.
I'm closing this bug just as described in Fedora's Policy for stalled package
reviews

http://fedoraproject.org/wiki/Policy_for_stalled_package_reviews

Note You need to log in before you can comment on or make changes to this bug.