Spec URL: http://cwickert.fedorapeople.org/review/lxdm-0.0.3-0.1.20091116svn2145.fc13.src.rpm SRPM URL: http://cwickert.fedorapeople.org/review/lxdm.spec Description: LXDM is the future display manager of LXDE, the Lightweight X11 Desktop environment. It is designed as a lightweight alternative to replace GDM or KDM in LXDE distros. It's still in very early stage of development. $ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/lxdm-* lxdm.src:27: W: unversioned-explicit-provides service(graphical-login) lxdm.x86_64: E: executable-marked-as-config-file /etc/lxdm/Xsession lxdm.x86_64: W: log-files-without-logrotate /var/log/lxdm.log The first is a virtual provides that all login managers have to indicate that anaconda should boot into runlevel 5 after install. The second can be ignored The latter can IMO be ignored too, lxdm will clear the log on shutdown, so there is no need for logrotate.
Review: Good: - sources generated as described: made a diff -r diff -r was not completely empty, some diffs in .svn If you'd have done tar ... --exclude=.svn ... this would be gone. (and a smaler package) - rpmlint ok as described - (version) naming according guidelines - Group ok - buildroot ok - macros everywhere - parallel builds enabled - permissions are ok - %files section is good, bad to look add, because of many %ghost and %config, but no packager fault - BR and R ok - nothing from %doc is required Needswork: - There is a GPLv3 COPYING, but some files contain GPLv2+ headers, other contain nothing at all. So some files are GPLv3 and others are GPLv2+. Probably they want to have anything GPLv2+. But for now, till this issue is resolved, you need to use GPLv3... Approving this, if you change it to GPLv3. ______________________ APPROVED
(In reply to comment #1) > If you'd have done tar ... --exclude=.svn ... this would be gone. > (and a smaler package) fixed > Approving this, if you change it to GPLv3. Ok, but I' pretty sure that it shuold be GPLv2+. Until I have confirmation from upstream, I'll use GPLv3+. Updated file at http://cwickert.fedorapeople.org/review/lxdm-0.0.3-0.2.20091116svn2145.fc13.src.rpm New Package CVS Request ======================= Package Name: lxdm Short Description: Lightweight X11 Display Manager Owners: cwickert Branches: F-11 F-12 InitialCC:
cvs done.
lxdm-0.0.3-0.2.20091116svn2145.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/lxdm-0.0.3-0.2.20091116svn2145.fc12
lxdm-0.0.3-0.2.20091116svn2145.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/lxdm-0.0.3-0.2.20091116svn2145.fc11
lxdm-0.0.3-0.2.20091116svn2145.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
lxdm-0.0.3-0.2.20091116svn2145.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.