Bug 540546 - xinit-compat Exec= key currently quite complex, simplify?
Summary: xinit-compat Exec= key currently quite complex, simplify?
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: xorg-x11-xinit
Version: rawhide
Hardware: All
OS: Linux
high
medium
Target Milestone: ---
Assignee: Matěj Cepl
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 490566 (view as bug list)
Depends On:
Blocks: 490566
TreeView+ depends on / blocked
 
Reported: 2009-11-23 16:21 UTC by Rex Dieter
Modified: 2018-04-11 12:54 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-02-27 11:03:36 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Rex Dieter 2009-11-23 16:21:42 UTC
/usr/share/xsession/xinit-compat.desktop
Exec=sh -c "exec ~/.xsession || exec ~/.Xclients || exec /etc/X11/xinit/Xclients"
is currently quite complex, and kdm doesn't grok it well (see bug #490566).

Mind doing a tiny bit of simplification, using something like
Exec=/usr/bin/xinit-compat
where /usr/bin/xinit-compat is a script that handles the heavy lifting...

#/bin/sh
for session in ~/.xsession ~/.Xclients /etc/X11/xinit/Xclients ; do
if [ -f ${session} ] ; then
  exec ${session}
fi
done


I've got this implemented already, and can do the packaging legwork, if this approach is agreeable.

Comment 1 Rex Dieter 2009-12-09 21:03:06 UTC
Ping, any comment ?

Comment 2 Rex Dieter 2010-01-19 13:37:17 UTC
ping ping (I'll wait another weekish or so, then "just do it" I guess).

Comment 3 Matěj Cepl 2010-02-03 17:38:05 UTC
(In reply to comment #0)
> Mind doing a tiny bit of simplification, using something like
> Exec=/usr/bin/xinit-compat
> where /usr/bin/xinit-compat is a script that handles the heavy lifting...

Sorry for taking so long to see this. I like the idea with one piece of doubt: /usr/bin? Wouldn't it be better to put the script somewhere away (/usr/libexec?, /usr/sbin/?, /etc/X11/xinit/?)?

Comment 4 Rex Dieter 2010-02-03 18:01:02 UTC
Good point, probably libexec then (ie, not user-visible).

Comment 5 Matěj Cepl 2010-02-03 23:45:56 UTC
http://koji.fedoraproject.org/koji/taskinfo?taskID=1961996
What do you think?

Comment 6 Rex Dieter 2010-02-23 20:32:41 UTC
Looks like a winner , though
%attr(755,-,root) %{_libexecdir}/xinit-compat
could be in the -session subpkg too (though it works as-is, not a big deal).

Comment 7 Matěj Cepl 2010-02-27 11:03:36 UTC
> Looks like a winner , though
> %attr(755,-,root) %{_libexecdir}/xinit-compat
> could be in the -session subpkg too (though it works as-is, not a big deal).    

Good point, changed and build for Rawhide
http://koji.fedoraproject.org/koji/taskinfo?taskID=2017475(In reply to comment #6)

Comment 8 Matěj Cepl 2010-02-27 11:04:13 UTC
In which other distros you would like to have this?

Comment 9 Rex Dieter 2010-03-13 21:43:50 UTC
At least F-13 too please, and F-12 too if it's not too much trouble (that's the release where the bug/issue was orginally reported).

Comment 10 Rex Dieter 2010-03-13 21:45:11 UTC
*** Bug 490566 has been marked as a duplicate of this bug. ***

Comment 11 Fedora Update System 2010-03-15 17:08:08 UTC
xorg-x11-xinit-1.0.9-15.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/xorg-x11-xinit-1.0.9-15.fc12

Comment 12 Matěj Cepl 2010-03-15 17:10:05 UTC
(In reply to comment #9)
> At least F-13 too please, and F-12 too if it's not too much trouble (that's the
> release where the bug/issue was orginally reported).    

https://admin.fedoraproject.org/updates/xorg-x11-xinit-1.0.9-15.fc12


Note You need to log in before you can comment on or make changes to this bug.