Bug 54068 - 'eth%%d' in pcnet32.o syslog message
Summary: 'eth%%d' in pcnet32.o syslog message
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Linux
Classification: Retired
Component: kernel
Version: 7.1
Hardware: i686
OS: Linux
medium
low
Target Milestone: ---
Assignee: Arjan van de Ven
QA Contact: Brock Organ
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2001-09-26 19:31 UTC by John Dalbec
Modified: 2007-04-18 16:37 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2001-09-27 09:04:35 UTC
Embargoed:


Attachments (Terms of Use)

Description John Dalbec 2001-09-26 19:31:18 UTC
From Bugzilla Helper:
User-Agent: Mozilla/4.77 [en] (X11; U; Linux 2.4.7-2.19 i686)

Description of problem:
The pcnet32 driver records the following message in syslog:
kernel: eth%%d: PCnet/FAST III 79C975 at 0x2000, 00 02 55 7c fd 01
This looks like it was supposed to print 'eth0' instead.

Version-Release number of selected component (if applicable):
2.4.3-15

How reproducible:
Always

Steps to Reproduce:
1. insmod pcnet32 on a machine with a compatible card
2.
3.
	

Actual Results:   
Message says 'eth%%d'.

Expected Results:   
Message probably intended to say 'eth0'.

Additional info:
alloc_etherdev passes a mask of 'eth%d' to alloc_netdev, apparently
expecting it to be used in a printf() call.  But alloc_netdev does a
strcpy() from the mask into dev->name.  I'm not sure how the % gets
doubled.
Is dev->name supposed to contain 'eth0' as pcnet32 seems to expect?  Or is
'eth%d' correct?

Comment 1 Arjan van de Ven 2001-09-27 09:04:30 UTC
Yup, bug indeed.

alloc_etherdev() is supposed to just copy it, register_etherdev actually assigns
the number. (There can be a long time in between, in which races would lead to
duplicate numbers etc)

I'll see if the printk can be moved down.


Note You need to log in before you can comment on or make changes to this bug.