Bug 541462 - Review Request: rasmol - Molecular Graphics Visualization Tool
Summary: Review Request: rasmol - Molecular Graphics Visualization Tool
Keywords:
Status: CLOSED DUPLICATE of bug 915144
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 523877 545045 545046 545047
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-11-25 23:32 UTC by Carl Byington
Modified: 2013-02-25 04:24 UTC (History)
10 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-04-24 18:52:40 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Carl Byington 2009-11-25 23:32:19 UTC
Spec URL: http://www.five-ten-sg.com/rasmol.spec
SRPM URL: http://www.five-ten-sg.com/rasmol-2.7.5-3.fc12.src.rpm
Description: RasMol is an X Window System tool intended for the visualization of
proteins and nucleic acids. It reads Brookhaven Protein Database (PDB)
files and interactively renders them in a variety of formats on either
an 8-bit or 24/32-bit color display.

Comment 1 Carl Byington 2009-11-28 21:46:05 UTC
koji scratch build now works.

http://www.five-ten-sg.com/rasmol.spec
http://www.five-ten-sg.com/rasmol-2.7.5-5.fc12.src.rpm

Comment 2 Stefan Riemens 2009-11-29 21:10:12 UTC
Just a really quick comment after skimming over the spec:

%{__cp} -a data %buildroot%{_datadir}/%{name}
%{__mv} %buildroot%{_libdir}/%{name}/* %buildroot%{_datadir}/%{name}
%{__install} -D -m 644 src/%{name}.png %buildroot%{_datadir}/icons/hicolor/48x48/apps/%{name}.png

Please use %{buildroot} consistently...

Stefan

Comment 4 Carl Byington 2009-11-30 15:55:19 UTC
scratch build koji reference:

http://koji.fedoraproject.org/koji/taskinfo?taskID=1838391

Comment 5 Carl Byington 2009-12-01 05:15:21 UTC
http://www.five-ten-sg.com/rasmol.spec
http://www.five-ten-sg.com/rasmol-2.7.5-7.fc12.src.rpm  

changes from ghemical review:
- create desktop file in %%prep
- remove __ macros

http://koji.fedoraproject.org/koji/taskinfo?taskID=1839653

Comment 6 Thomas Spura 2009-12-04 00:37:31 UTC
I don't find the relevant section in the guidelines, but I *believe* to remember, that you are not allowed to package 5 packages into this one.

Don't you *have* to package cqrlib, cvector, neartree and cbflib first and at the end rasmol on its own??

As already said, I could be wrong here, but don't think so...

Comment 7 tjyuviaej 2009-12-04 01:15:47 UTC
I have RPMs for packages of cqrlib, cvector, neartree and cbflib and they available at
http://t-matsuu.sakura.ne.jp/install-memo/fedora/repoview/

I can fit them to fedora.

After fitting my RPMs to Fedora, I'll create Fedora account and create review process shortly.

Comment 8 Takanori MATSUURA 2009-12-04 01:36:57 UTC
Please ignore the account for comment #7.
It's for crash reporter account.

Anyway, I'll make RPMs for Fedora.

Comment 9 Takanori MATSUURA 2009-12-07 12:46:07 UTC
Package review of cbflib, cqrlib, cvector, and neartree are filed in bug 545044, bug 545045, bug 545046, and bug 545047 respectively.

Comment 10 Takanori MATSUURA 2009-12-09 12:52:19 UTC
For CBFlib, see bug 523877.
Sorry.  I forgot to check it.

I suggest this bug is depended on bug 523877, bug 545045, bug 545046, and bug 545047.

Comment 11 Dmitrij S. Kryzhevich 2010-08-24 11:49:24 UTC
(In reply to comment #10)
> For CBFlib, see bug 523877.
> Sorry.  I forgot to check it.
> 
> I suggest this bug is depended on bug 523877, bug 545045, bug 545046, and bug
> 545047.

If nobody want to continue the work on including rasmol and other packages from list above into Fedora repo I could try to do it (need sponsor but could).

Comment 12 Takanori MATSUURA 2010-08-24 15:30:01 UTC
(In reply to comment #11)
> If nobody want to continue the work on including rasmol and other packages from
> list above into Fedora repo I could try to do it (need sponsor but could).

For dependent packages which are assigned to me, I'm now in training to get sponsor. See bug 545046.

Comment 13 Dmitrij S. Kryzhevich 2010-08-25 01:31:42 UTC
Ah, grate! Waiting rasmol in Fedora repo.

Comment 14 Susi Lehtola 2010-08-25 05:50:31 UTC
(In reply to comment #6)
> I don't find the relevant section in the guidelines, but I *believe* to
> remember, that you are not allowed to package 5 packages into this one.
> 
> Don't you *have* to package cqrlib, cvector, neartree and cbflib first and at
> the end rasmol on its own??
> 
> As already said, I could be wrong here, but don't think so...

Yes, this is explicitly banned in the guidelines:

http://fedoraproject.org/wiki/Packaging/Guidelines#Bundling_of_multiple_projects
http://fedoraproject.org/wiki/Packaging/Guidelines#Duplication_of_system_libraries

Comment 15 Takanori MATSUURA 2010-12-09 11:29:42 UTC
Where is the latest Spec and SRPM files?

Comment 16 Chen Lei 2010-12-09 15:21:47 UTC
(In reply to comment #15)
> Where is the latest Spec and SRPM files?

CBFlib isn't available in Fedora yet.

Comment 17 Takanori MATSUURA 2010-12-09 15:55:06 UTC
I'd like to add GTK2 support for el6 and Fedora 13-15 based on Carl's SRPM because it is reviewed here. However I cannot get spec and SRPM files from www.five-ten-sg.com website.

If Carl doesn't have enough time, I can work.

Comment 18 Carl Byington 2010-12-10 02:11:34 UTC
I don't have time to package the four dependencies cqrlib, cvector, neartree and cbflib. I think the cleanest way is to autoconf them, which I did for cqrlib. That same method should work for the other three.

http://www.five-ten-sg.com/cqrlib.spec
http://www.five-ten-sg.com/CQRlib-1.0.6.tar.gz
http://www.five-ten-sg.com/autoconf-files.tar.gz

http://www.five-ten-sg.com/CQRlib-1.0.6-1.fc12.src.rpm
http://www.five-ten-sg.com/rasmol.spec

Once those four are accepted into Fedora, there is not much more to do to get rasmol itself accepted.

Comment 19 Dmitrij S. Kryzhevich 2012-02-27 06:13:03 UTC
Ping?

Comment 20 Takanori MATSUURA 2012-02-27 10:50:24 UTC
I'll catch up.

Comment 21 Jason Tibbitts 2012-04-24 18:52:40 UTC
No response in some time; I'm going to go ahead and close this.  If someone besides Carl wishes to submit this package, please open your own review ticket.  Thanks.

Comment 22 Dmitrij S. Kryzhevich 2013-02-25 04:24:04 UTC

*** This bug has been marked as a duplicate of bug 915144 ***


Note You need to log in before you can comment on or make changes to this bug.