Spec URL: http://bakeyournoodle.com/~tony/fedora/garmin-sync/garmin-sync.spec SRPM URL: http://bakeyournoodle.com/~tony/fedora/garmin-sync/garmin-sync-0.3-3.fc12.src.rpm Description: garmin-sync allows you to download information from your Garmin Edge and Forerunner devices. NOTE: this is a review request as garmin-sync has been orphaned/retired for F-12 but is still maintained for F-11. I'd like to maintain it for F-12 and later.
FWIW, here is a koji build and RPMlint output http://koji.fedoraproject.org/koji/taskinfo?taskID=1831252 [tony@thor F-12]$ rpmlint -vi *spec ~/Download/garmin-sync* garmin-sync.noarch: I: checking garmin-sync.src: I: checking 2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Not sure why nobody has looked at this yet; there's not much to it. It still builds OK and installs on rawhide. I haven't any hardware I could use to test it but I suspect that given that upstream is dead and nothing has changed, it will work as well as it ever did. For modern Fedora there are a few things you can remove: BuildRoot, %clean and the first line of %install. Otherwise rpmlint just complains about the lack of a manpage. That's always nice to fix but it's not essential. APPROVED * source files match upstream. sha256sum: efc4e1410d22a50ebe58e09d291ee0e46254cb6e0f367f2e3b569df848ff5dfb garmin-sync-0.3.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint has acceptable complaints. * final provides and requires are sane: garmin-sync = 0.3-3.fc15 = /usr/bin/env pyusb * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package.
Hello? It's been a month since I spent the time to review this. Could I at least get a reply? If nothing happens, I guess I'll have to revoke my approval and close this ticket out.
Very sorry for the latency. I've never written a manpage from scratch before but I'll have a stab at it. I've addressed your points and uploaded a rpms and the spec file to: http://bakeyournoodle.com/~tony/fedora/garmin-sync/ I'll wait a couple of days before filing the SCM request, in case you see any mistakes. Thanks for the review.
Sometimes you can filch manpages from Debian, which has a stronger requirement for packagers to add missing manpages. There wasn't really anything you needed to address, though the new package looks OK as well. Feel free to make your SCM request at any time.
Package Change Request ====================== Package Name: garmin-sync New Branches: F-13 F-14 Owners: tbreeds InitialCC: Package was retired in F-12 please revive it :)
Git done (by process-git-requests).
I created the new branches; you should log into pkgdb and claim the devel branch.
Done Thanks. I'll get a build done ASAP to close this ticket.
As far as I can tell, there have still been no post-F12 builds of this package. If there's something I can help you with, please let me know. Otherwise I guess I'll go ahead and get this re-orphaned and blocked.
(In reply to comment #10) > As far as I can tell, there have still been no post-F12 builds of this package. > If there's something I can help you with, please let me know. Otherwise I > guess I'll go ahead and get this re-orphaned and blocked. Well 4 months certainly doesn't count as "soon" but I've done the import locally. I need to get a f15 branch created and then get rel-eng to unblock it.
Package Change Request ====================== Package Name: garmin-sync New Branches: f15 Owners: tbreeds
garmin-sync-0.3-4.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/garmin-sync-0.3-4.fc14
garmin-sync-0.3-4.fc14 has been pushed to the Fedora 14 testing repository.
garmin-sync-0.3-4.fc14 has been pushed to the Fedora 14 stable repository.