SRPM: http://mmaslano.fedorapeople.org/MergeReview/perl-Pod-Coverage-0.20-3.fc13.src.rpm Spec: http://mmaslano.fedorapeople.org/MergeReview/perl-Pod-Coverage.spec Description: Developers hate writing documentation. They'd hate it even more if their computer tattled on them, but maybe they'll be even more thankful in the long run. Even if not, perlmodstyle tells you to, so you must obey. This module provides a mechanism for determining if the pod for a given module is comprehensive.
I wonder how can this package got missed at time of FC-6 when all core packages submitted for their merge-reviews.
Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1863811 + rpmlint is silent for SRPM and for RPM. + source files match upstream url (sha1sum) c4786c39ae5a53ae6dbf553071d1e6f707deba61 Pod-Coverage-0.20.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=9, Tests=71, 1 wallclock secs ( 0.04 usr 0.01 sys + 0.48 cusr 0.08 csys = 0.61 CPU) + Package perl-Pod-Coverage-0.20-3.fc13.noarch => Provides: perl(Pod::Coverage) = 0.20 perl(Pod::Coverage::CountParents) perl(Pod::Coverage::ExportOnly) perl(Pod::Coverage::Extractor) perl(Pod::Coverage::Overloader) Requires: /usr/bin/perl perl(B) perl(Devel::Symdump) perl(Pod::Coverage) perl(Pod::Find) perl(Pod::Parser) perl(base) perl(constant) perl(lib) perl(strict) perl(vars) + Not a GUI application APPROVED.
Thank you for you review.