Created attachment 374408 [details] The proposed patch (patch of patch, not sure if that's handled correctly) Description of problem: In libsgmodel.so, there are undefined references to functions defined in libOsgParticle. The attached patch to SimGear-1.9.1-shared.patch prevents this, by adding -losgparticle to the linker flags. Version-Release number of selected component (if applicable): SimGear-1.9.1-8.fc12.i686 How reproducible: This problem shows up when trying to compile fgrun 1.5.1 against the current simgear. The patch fixes this. Actual results: g++ -DLOCALEDIR=\"/usr/local/share/locale\" -g -O2 -o fgrun wizard.o wizard_funcs.o advanced.o advanced_funcs.o AirportBrowser.o AirportTable.o Fl_Table.o Fl_Table_Row.o Fl_OSG.o Fl_Heading_Dial.o main.o io.o fgfsrc.o logwin.o parkingloader.o settings.o util.o run_posix.o fgrun_pty.o -lsgmodel -lsgmath -lsgscreen -lsgprops -lsgxml -lsgmisc -lsgdebug -lsgstructure -lsgutil -lplibsg -lplibul -losgSim -losgViewer -losgGA -losgText -losgDB -losgUtil -losg -lOpenThreads -lfltk_gl -lpthread -lfltk -lXft -lGL -lXmu -lXt -lSM -lICE -lXi -lXext -lX11 -lm -lz -lutil -losgFX /usr/lib/gcc/i686-redhat-linux/4.4.2/../../../libsgmodel.so: undefined reference to `osgParticle::ModularEmitter::ModularEmitter()' /usr/lib/gcc/i686-redhat-linux/4.4.2/../../../libsgmodel.so: undefined reference to `osgParticle::ParticleSystem::ParticleSystem()' /usr/lib/gcc/i686-redhat-linux/4.4.2/../../../libsgmodel.so: undefined reference to `osgParticle::ParticleSystemUpdater::ParticleSystemUpdater()' /usr/lib/libsgenvironment-1.9.1.so: undefined reference to `osgParticle::PrecipitationEffect::rain(float)' /usr/lib/libsgenvironment-1.9.1.so: undefined reference to `osgParticle::PrecipitationEffect::snow(float)' /usr/lib/gcc/i686-redhat-linux/4.4.2/../../../libsgmodel.so: undefined reference to `osgParticle::MultiSegmentPlacer::MultiSegmentPlacer()' /usr/lib/libsgenvironment-1.9.1.so: undefined reference to `osgParticle::PrecipitationEffect::PrecipitationEffect()' /usr/lib/gcc/i686-redhat-linux/4.4.2/../../../libsgmodel.so: undefined reference to `osgParticle::ParticleSystem::setDefaultAttributes(std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, bool, bool, int)' /usr/lib/gcc/i686-redhat-linux/4.4.2/../../../libsgmodel.so: undefined reference to `osgParticle::FluidProgram::FluidProgram()' /usr/lib/gcc/i686-redhat-linux/4.4.2/../../../libsgmodel.so: undefined reference to `osgParticle::ConnectedParticleSystem::ConnectedParticleSystem()' collect2: ld returned 1 exit status make[2]: *** [fgrun] Error 1 make[2]: Leaving directory `/home/stefan/flightgear/native/fgrun-1.5.1/src' make[1]: *** [all] Error 2 make[1]: Leaving directory `/home/stefan/flightgear/native/fgrun-1.5.1/src' make: *** [all-recursive] Error 1 Expected results: This should just link Additional info: The attached patch works fine, I haven't found any regressions.
Created attachment 374409 [details] My new srpm, I used for testing
SimGear-1.9.1-9.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/SimGear-1.9.1-9.fc12
SimGear-1.9.1-7.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/SimGear-1.9.1-7.fc11
Thanks! That was quick indeed :) Stefan
SimGear-1.9.1-7.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update SimGear'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-12397
SimGear-1.9.1-9.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update SimGear'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2009-12411
SimGear-1.9.1-9.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
SimGear-1.9.1-7.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.