SPEC: http://v3.sk/~lkundrak/SPECS/patricia-trie.spec SRPM: http://v3.sk/~lkundrak/SRPMS/patricia-trie-0.2-1.20091116svn.fc12.src.rpm Description: Patricia is a prefix-tree (trie) implementation written in Java.
Hi, I'm not (yet) a packager, anyway I'd like to make an informal review of your package. * You should not rely explicitely on OpenJDK in your BuildRequires; use instead: Buildrequires: java-devel >= 1:1.6.0 as suggested in https://fedoraproject.org/wiki/Packaging/Java#BuildRequires_and_Requires Don't forget by the way to add a Java runtime by using: Requires: java >= 1:1.6.0 Did you tried to build your package with gcj by the way? * You should maybe in your javadoc subpackage add a Requires on "%{name} = %{version}-%{release}" also, as recommended here: https://fedoraproject.org/wiki/Packaging/Java#ant_2 Except these two points, your package seems OK. I rebuild your SRPM, it works fine and rpmlint doesn't complains :-)
(In reply to comment #1) > Hi, > > I'm not (yet) a packager, anyway I'd like to make an informal review of your > package. > > * You should not rely explicitely on OpenJDK in your BuildRequires; use > instead: > Buildrequires: java-devel >= 1:1.6.0 > as suggested in > https://fedoraproject.org/wiki/Packaging/Java#BuildRequires_and_Requires > Don't forget by the way to add a Java runtime by using: > Requires: java >= 1:1.6.0 Given the java packages don't follow uniform versioning, requiring a version with epoch will only drag in OpenJDK anyway. I'm requiring the unversioned OpenJDK so that the package works on other RPM-based platforms (openSUSE). In fact Fedora OpenJDK's generic provides should probably be fixed to provide epoch-less versions (despite the package itself providing the epoch). > Did you tried to build your package with gcj by the way? Yup. Did not work, did not bother to find out why, just switched to OpenJDK. > > * You should maybe in your javadoc subpackage add a Requires on "%{name} = > %{version}-%{release}" also, as recommended here: > https://fedoraproject.org/wiki/Packaging/Java#ant_2 Good point, will do once the official review is done. > Except these two points, your package seems OK. I rebuild your SRPM, it works > fine and rpmlint doesn't complains :-) Thank you.
Thank you Mohamed for the review, it looks fine.
New Package CVS Request ======================= Package Name: patricia-trie Short Description: Java prefix tree library Owners: lkundrak Branches: F-11 F-12 EL-5
cvs done
Imported and built.