Spec URL: http://cassmodiah.fedorapeople.org/yagtd/yagtd.spec SRPM URL: http://cassmodiah.fedorapeople.org/yagtd/yagtd-0.3.0-1.fc12.noarch.rpm Description:**yaGTD** project is a very simple utility designed to make the management of your to-do list quick and easy.
Some quick comments as mentioned on IRC: 1. you need to upload the SRPM, not the RPM (you should add a link to a koji scratch build of the package) 2. You need to click through the fedora-cla - without that you cannot become a packager 3. Something needs to be done about the 1.4 MiB scan of the 'mindmap' - it either needs to be dropped or moved to a -docs-subpackage. That png is much much larger than the rest of the package.
(In reply to comment #1) > 1. you need to upload the SRPM, not the RPM (you should add a link to a koji > scratch build of the package) my fault! http://cassmodiah.fedorapeople.org/yagtd/yagtd-0.3.0-1.fc12.src.rpm http://koji.fedoraproject.org/koji/taskinfo?taskID=1836547 btw, you know that only members of the packer-group can use koji? > 3. Something needs to be done about the 1.4 MiB scan of the 'mindmap' - it > either needs to be dropped or moved to a -docs-subpackage. That png is much > much larger than the rest of the package. The 'mindmap' is a bad file for a documentation. It should be dropped. It's not a meaningfully file.
> btw, you know that only members of the packer-group can use koji? AFAIK this is wrong. Everyone who has signed/clicked-through the cla can submit scratch builds.
(In reply to comment #3) > AFAIK this is wrong. Everyone who has signed/clicked-through the cla can submit > scratch builds. Yes, you are right... There is a delay... Fabian tried it too early!
Is there an update on this? I see here -> http://download.gna.org/yagtd/ that there is a version 0.3.3 released. The spec file (Version and %changelog) should be updated to reflect this. While I can't sponsor you, I am happy to review this once I can tell you are still working on this. Thanks! Chris
Thanks for responding to this review. I'm on it asap.
koji scratch build https://koji.fedoraproject.org/koji/taskinfo?taskID=2274854 Spec file http://underscores.fedorapeople.org/yagtd.spec SRPM http://underscores.fedorapeople.org/yagtd-0.3.3-1.fc13.src.rpm Thanks for your reply.
I added a doc package new koji scratch build http://koji.fedoraproject.org/koji/taskinfo?taskID=2276206 new Spec file http://underscores.fedorapeople.org/yagtd.spec new srpm http://underscores.fedorapeople.org/yagtd-0.3.3-1.fc13.src.rpm
I made some changes (and sorry for that missing release update) new koji scratch build http://koji.fedoraproject.org/koji/taskinfo?taskID=2278487 the spec file has still the same URL the new SRPM is http://underscores.fedorapeople.org/yagtd-0.3.3-3.fc13.src.rpm
I updated the spec file to the lates verstion: here is the lates scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2418439 here the latest srpm: http://underscores.fedorapeople.org/yagtd-0.3.4-5.fc13.src.rpm
This builds fine and generally looks OK, but before I invest the time to do a review I'd like to ask if you still wish to submit this package. Also, have you done any other package review work? Have you read https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group and done any of the things recommended there? Finally, why does this block the PyCAM review ticket? That package doesn't seem to depend on this one.
(In reply to comment #11) > Finally, why does this block the PyCAM review ticket? That package doesn't > seem to depend on this one. That actually was me, because - at least to my knowledge - Fabian still needs to be sponsored with his first package, which is this one. I unfortunately am not able to sponsor him, but thought I can proceed with the PyCAM review first, when Fabian finally has a sponsor? *a bit confused*
I know Fabian and I will sponsor him. Stay tuned for the formal review.
Just a response to comment #12. There is no requirement whatsoever that the first package submitted be the first one reviewed. If you see some documentation that indicates that, please point it out because it is incorrect. The requirement is that only sponsors can review the tickets of new packagers. It doesn't matter which of their tickets are reviewed; once they are sponsored, any packager can review their other tickets (although generally a sponsor will review multiple tickets submitted by the same new packager).
any progress here?
I was not aware this is assigned to me. Feel free to take over if you want to sponsor Fabian. I am currently very busy.
I stumbled upon this just by accident. Fabian, are you still interested?
Yes, I would like to go on with this. But I have a lot to do right now. I will try to find some time this week and look if there are any updates on this software (as the review request is very old).
OK Fabian, then I'd say, just give me a ping, when you're ready (and remove NotReady from Whiteboard field).