Bug 543660 - Perl Archive::Zip fails writing to an unseekable file handle after calling desiredCompressionLevel()
Summary: Perl Archive::Zip fails writing to an unseekable file handle after calling de...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: perl-Archive-Zip
Version: rawhide
Hardware: All
OS: Linux
urgent
high
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-12-02 19:44 UTC by Javier Alejandro Castro
Modified: 2016-08-14 13:56 UTC (History)
8 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-08-14 13:56:06 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Zip file with error displayed on top of it (305 bytes, application/zip)
2009-12-02 19:44 UTC, Javier Alejandro Castro
no flags Details


Links
System ID Private Priority Status Summary Last Updated
CPAN 54827 0 None None None Never

Description Javier Alejandro Castro 2009-12-02 19:44:14 UTC
Created attachment 375572 [details]
Zip file with error displayed on top of it

Description of problem:

When i try to restore as zip to download a backup, i get a wrong generated zip file.

Version-Release number of selected component (if applicable):

BackupPC-3.1.0-9.fc12.noarch

How reproducible:

Always

Steps to Reproduce:
1. Make a backup with BackupPC
2. Try to restore that backup as a zip file
  
Actual results:

Wrong empty zip file

Expected results:

Nice zip file

Additional info:

I've managed to get the error produced internally on the call to BackupPC_zipCreate, and it is:

Can't locate object method "tell" via package "IO::Handle" at /usr/lib/perl5/vendor_perl/5.10.0/Archive/Zip/Member.pm line 746.

Comment 1 Javier Alejandro Castro 2009-12-15 21:52:39 UTC
Please, somebody can help me with this? May be i must contact somebody from BackuPC team directly?

Thanks!

Comment 2 Johan Cwiklinski 2010-01-13 19:53:33 UTC
Unfortunately, I cannot help a lot for now :/

Trying to run from shell with the following command : 
/usr/share/BackupPC/bin/BackupPC_zipCreate -h localhost -n1 -s / /etc > test/zip

Produces a well formed zip file. Trying from web interface produces not well formed zip file, but I cannot find any related error (backuppc's log file does not help).

How did you get the error you report for Member.pm?

Comment 3 Javier Alejandro Castro 2010-01-13 22:06:33 UTC
To get the error, i did the following trick:

Patch file /usr/share/BackupPC/lib/BackupPC/CGI/Restore.pm.
Find the place where BackupPC_zipCreate is called.

------------
       $In{compressLevel} = 5 if ( $In{compressLevel} !~ /^\d+$/ );
       #
       # Fork the child off and manually copy the output to our stdout.
       # This is necessary to ensure the output gets to the correct place
       # under mod_perl.
       #
       $bpc->cmdSystemOrEvalLong(["$BinDir/BackupPC_zipCreate",
                "-h", $host,
                "-n", $num,
                "-c", $In{compressLevel},
                "-s", $share,
                @pathOpts,
                @fileList
           ],
           sub { print(@_); },
           1,                  # ignore stderr
       );
-----------------------

look at the #ignore stderr...
What i did was replace the "1," for a "0," so on the produced "zip"
file, i get the error message i previously posted.

Hope this helps you to fix that nasty bug!

Thanks!

Comment 4 Johan Cwiklinski 2010-01-15 17:27:31 UTC
I cannot fix that issue myself ; I'll have to report this upstream (that has already been reported but with no solution for now: http://sourceforge.net/mailarchive/forum.php?thread_name=20091002231440.GA15804%40gratch.parplies.de&forum_name=backuppc-users)

Could you try to restore as a zip file from the command line ?

I can only reproduce the issue when using the web interface ; from the command line all is ok for me.

You can see on the backuppc's mailing list that there is no issue when you try to get a not compressed zip file ; maybe that could help you until bug gets fixed.

Comment 5 Javier Alejandro Castro 2010-01-15 20:10:57 UTC
I'wait for the upstream fix. Thanks anyway!

Comment 6 Johan Cwiklinski 2010-01-16 09:28:41 UTC
Okay, I've posted on upstream list:
http://sourceforge.net/mailarchive/forum.php?thread_name=4B517AF7.7030403%40x-tnd.be&forum_name=backuppc-users

Hope that'll be fixed.

Comment 7 Johan Cwiklinski 2010-02-21 07:18:56 UTC
Thanks to BackupPC mlain developper, issue has been found: http://sourceforge.net/mailarchive/message.php?msg_name=451b3c19-58a8-430c-9cb5-e10e06f323a4%40SC1EXHC-02.global.atheros.com

That's a bug in the Perl Archive::Zip module, aptch has been submitted upstream for this: https://rt.cpan.org/Public/Bug/Display.html?id=54827

Comment 8 Marcela Mašláňová 2010-04-21 13:19:45 UTC
This bug report wasn't reviewed by upstream. You can check their new development version, which doesn't contain this fix, but it might be fixed elsewhere in code. Please test it:
http://search.cpan.org/~adamk/Archive-Zip/

Comment 9 Petr Pisar 2010-06-22 12:12:13 UTC
Upstream 1.31_01 version improves Win32 support only according diff.

I checked the test case from RT against 1.31_01, and it does not fix this issue.

Comment 10 Bug Zapper 2010-11-04 04:33:29 UTC
This message is a reminder that Fedora 12 is nearing its end of life.
Approximately 30 (thirty) days from now Fedora will stop maintaining
and issuing updates for Fedora 12.  It is Fedora's policy to close all
bug reports from releases that are no longer maintained.  At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '12'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 12's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 12 is end of life.  If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora please change the 'version' of this 
bug to the applicable version.  If you are unable to change the version, 
please add a comment here and someone will do it for you.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 11 Petr Pisar 2010-11-04 08:40:47 UTC
All Fedoras (15--12) affected as all of them ship the same Archive::Zip module version 1.30. The bug has not been fixed by upstream yet.

Comment 12 Jeff Raber 2010-12-08 02:46:53 UTC
Improved summary (copied from upstream bug) and cleared the NEEDINFO flag



-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

Comment 13 Bug Zapper 2011-06-02 17:13:55 UTC
This message is a reminder that Fedora 13 is nearing its end of life.
Approximately 30 (thirty) days from now Fedora will stop maintaining
and issuing updates for Fedora 13.  It is Fedora's policy to close all
bug reports from releases that are no longer maintained.  At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '13'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 13's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 13 is end of life.  If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora please change the 'version' of this 
bug to the applicable version.  If you are unable to change the version, 
please add a comment here and someone will do it for you.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 14 Marcela Mašláňová 2011-10-17 11:33:32 UTC
I keep this bug report for tracking progress in upstream.

Comment 15 Marcela Mašláňová 2012-03-19 12:21:32 UTC
I applied the reasonable patch from upstream tracker. Hope it helps. Could someone from reporters test it and let me know?
I can apply the patch for released Fedora if needed.

Comment 16 Marcela Mašláňová 2012-03-19 12:30:25 UTC
The build is currently only for rawhide:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3909235

I let this bug open for tracking upstream changes.

Comment 17 Fedora End Of Life 2013-04-03 19:48:31 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 19 development cycle.
Changing version to '19'.

(As we did not run this process for some time, it could affect also pre-Fedora 19 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 19 End Of Life. Thank you.)

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora19

Comment 18 Fedora Admin XMLRPC Client 2013-08-12 12:29:56 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 19 Fedora End Of Life 2015-01-09 21:41:10 UTC
This message is a notice that Fedora 19 is now at end of life. Fedora 
has stopped maintaining and issuing updates for Fedora 19. It is 
Fedora's policy to close all bug reports from releases that are no 
longer maintained. Approximately 4 (four) weeks from now this bug will
be closed as EOL if it remains open with a Fedora 'version' of '19'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 19 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 20 Fedora End Of Life 2015-05-29 08:36:38 UTC
This message is a reminder that Fedora 20 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 20. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '20'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 20 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 21 Fedora End Of Life 2015-11-04 15:30:05 UTC
This message is a reminder that Fedora 21 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 21. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '21'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 21 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 22 Fedora End Of Life 2015-12-02 02:32:17 UTC
Fedora 21 changed to end-of-life (EOL) status on 2015-12-01. Fedora 21 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 23 Paul Howarth 2015-12-03 11:06:40 UTC
This issue is patched in all current Fedora releases; keeping this bug open to track upstream activity as per Comment #16.

Comment 24 Emmanuel Seyman 2016-08-14 13:56:06 UTC
The patch was merged by upstream in Archive-Zip 1.49.
Given that all supported versions of Fedora use this version or higher, I'm going to close this bug.


Note You need to log in before you can comment on or make changes to this bug.