Spec URL: http://people.freedesktop.org/~hughsient/temp/upower.spec SRPM URL: http://people.freedesktop.org/~hughsient/temp/upower-0.9.1-0.1.20091204git.fc12.src.rpm Description: DeviceKit-power recently got renamed to upower, see http://lists.freedesktop.org/archives/devkit-devel/2009-December/000567.html so it is only proper to change the Fedora package name too. This package will obsolete (and provide - for transitioning) DeviceKit-power when we have converted the applications to use upower. It's expected DeviceKit-power and upower will co-exist for a couple of weeks to ease the pain a little. See https://bugzilla.redhat.com/show_bug.cgi?id=543608 for more information. [hughsie@hughsie-work devel]$ rpmlint /home/hughsie/rpmbuild/*RPM*/upower* upower.i686: W: non-conffile-in-etc /etc/dbus-1/system.d/org.freedesktop.UPower.conf 4 packages and 0 specfiles checked; 0 errors, 1 warnings. Thanks for reviewing this.
builds fine in mock. rpmlint says: [mclasen@planemask Desktop]$ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm upower.x86_64: W: non-conffile-in-etc /etc/dbus-1/system.d/org.freedesktop.UPower.conf 4 packages and 0 specfiles checked; 0 errors, 1 warnings. The one warning is ignorable, files in /etc/dbus-1/system.d are not supposed to be config files (there was some upstream discussion in dbus to move this directory elsewhere, it may still happen).
Looking at the docs, I notice that Upower.7 refers to DeviceKit(7) - that should probably be removed. Formal review: package name: ok spec file name: ok packaging guidelines: Requires(post): /sbin/ldconfig Requires(postun): /sbin/ldconfig These are not necessary when using %post(un) -p Requires: dbus >= %{dbus_version} Requires: dbus-glib >= %{dbus_glib_version} Requires: glib2 >= %{glib2_version} Requires: polkit >= %{polkit_version} The guidelines now have language that forbids explicit requires where an automatic library dep suffices. You probably want the explicit dep on dbus (for the daemon), so just add a comment there; but dbus-glib, glib2, polkit are probably all unnecessary. Might be good to compare with what david has done in upower. -devel should require gtk-doc for %{_datadir}/gtk-doc/html/, I think. mkdir -p $RPM_BUILD_ROOT%{_datadir}/doc/%{name}-%{version} cp README AUTHORS NEWS COPYING HACKING doc/TODO $RPM_BUILD_ROOT%{_datadir}/doc/%{name}-%{version} Why are you doing this ? Just %doc README AUTHORS NEWS... in the file list should suffice. License: ok to be continued...
Just a few other comments: - %configure --disable-static works, no need to rm *.a - https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define
A bit more explicit listing in %files would not hurt.
License: field: ok License file: ok Spec file language: ok Spec file readable: ok Upstream sources: tarball missing Buildable: ok ExcludeArch: ok, none BuildRequires: ok locale handling: ok, none ldconfig: ok system libraries: ok relocatable: ok, no directory ownership: ok duplicate files: ok permissions: ok %clean: ok macro use: ok permissible content: ok large docs: ok, none %doc content: ok header files: ok static libs: ok, none pc files: ok shared libs: ok devel deps: ok .la files: ok gui apps: ok, none file ownership: ok %install: ok utf8 filenames: ok
New release, new srpm, new spec: http://people.freedesktop.org/~hughsient/temp/upower-0.9.1-1.fc13.src.rpm http://people.freedesktop.org/~hughsient/temp/upower.spec [hughsie@work Desktop]$ rpmlint ~/rpmbuild/SRPMS/upower-*.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [hughsie@work Desktop]$ rpmlint ~/rpmbuild/RPMS/upower-* upower.i686: W: non-conffile-in-etc /etc/dbus-1/system.d/org.freedesktop.UPower.conf 3 packages and 0 specfiles checked; 0 errors, 1 warnings. Thanks.
Ok, source is ok now. Approved.
If the linked spec is the correct one, there are several strange things here: Requires: dbus-glib >= %{dbus_glib_version} Requires: glib2 >= %{glib2_version} Requires: polkit >= %{polkit_version} The %doc thing is way off: mkdir -p $RPM_BUILD_ROOT%{_datadir}/doc/%{name}-%{version} cp README AUTHORS NEWS COPYING HACKING $RPM_BUILD_ROOT%{_datadir}/doc/%{name}-%{version} %doc %dir %{_datadir}/doc/%{name}-%{version} %doc %{_datadir}/doc/%{name}-%{version}/NEWS %doc %{_datadir}/doc/%{name}-%{version}/COPYINGRequires(post): /sbin/ldconfig Requires(postun): /sbin/ldconfig %doc %{_datadir}/doc/%{name}-%{version}/AUTHORS %doc %{_datadir}/doc/%{name}-%{version}/HACKING %doc %{_datadir}/doc/%{name}-%{version}/README What?? File listing is not good, please be more explicit. The %define is useless, and should be %global any way. Is these needed: Requires(post): /sbin/ldconfig Requires(postun): /sbin/ldconfig
And please change status to assigned.
Not sure what you think is wrong with the polkit requires. The library deps could certainly be dropped, and yes, the way the %doc is handled is odd. The file list is just fine though.
I guess I missed the fact that I had my formal review split in two comments here. Richard, can you fix up the few things I pointed out in comment 2 ?
Created attachment 397598 [details] Patch to fix most of the strangeness
Note: I had to comment out the gir files, they were not created on my F12 system. Another issue: compiling is silent so it's impossible to verify that %{optflags} are being used during build.
New spec for review, thanks: http://people.freedesktop.org/~hughsient/temp/upower.spec
Seems good, Matthias?
Yes, looks good to me now. Flag is already set...
Please set fedora-cvs flags to continue.
New Package CVS Request ======================= Package Name: upower Short Description: Power management service Owners: rhughes Branches: F-12 F-13 InitialCC: rhughes Thanks!
CVS done (by process-cvs-requests.py).
Thanks!