Bug 544570 - Review Request: attica - Implementation of the Open Collaboration Services API
Summary: Review Request: attica - Implementation of the Open Collaboration Services API
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jaroslav Reznik
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-12-05 13:19 UTC by Lorenzo Villani
Modified: 2009-12-16 17:49 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-12-16 17:49:43 UTC
Type: ---
Embargoed:
jreznik: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Lorenzo Villani 2009-12-05 13:19:08 UTC
Spec URL: http://gitorious.org/lvillani/specs/blobs/master/kde/attica/attica.spec
SRPM URL: http://fedorapeople.org/~arbiter/attica/

Description: Attica is a Qt library that implements the Open Collaboration Services
API version 1.4.

Comment 1 Lorenzo Villani 2009-12-05 13:28:02 UTC
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1851262
________________________________________________________________

Rpmlint:
[lvillani@enterprise attica]$ rpmlint /home/lvillani/devel/rpm/RPMS/x86_64/attica-0.1.0-1.fc12.x86_64.rpm /home/lvillani/devel/rpm/RPMS/x86_64/attica-devel-0.1.0-1.fc12.x86_64.rpm attica.spec
attica-devel.x86_64: W: no-documentation
2 packages and 1 specfiles checked; 0 errors, 1 warnings.

I decided to include "documentation" (mainly license and readme file) only in the main package.

Comment 2 Kevin Kofler 2009-12-06 01:14:06 UTC
> attica-devel.x86_64: W: no-documentation

This one can be ignored (all the documentation is in the main package which is required by -devel).

Comment 3 Jaroslav Reznik 2009-12-07 19:42:14 UTC
SPEC file looks ok.

in build section please use

mkdir -p %{_target_platform}
pushd %{_target_platform}   
%{cmake}
popd                          

make %{?_smp_mflags} -C %{_target_platform}

Comment 4 Rex Dieter 2009-12-07 19:48:50 UTC
make that

%{cmake} ..

(the '..' was missing)

Comment 5 Jaroslav Reznik 2009-12-07 19:53:34 UTC
ah sorry - copy/paste issue from other SPEC file (and removing option!)

use appropriate install section

make install/fast DESTDIR=%{buildroot} -C %{_target_platform}

Comment 6 Lorenzo Villani 2009-12-07 20:08:40 UTC
* Mon Dec  7 2009 Lorenzo Villani <lvillani> - 0.1.0-2
- Out of sourcetree build
- Use make install/fast

Comment 7 Jaroslav Reznik 2009-12-07 20:12:40 UTC
It looks ok for me, thanks!

APPROVED

Comment 8 Lorenzo Villani 2009-12-07 20:19:48 UTC
New Package CVS Request
=======================
Package Name: attica
Short Description: Implementation of the Open Collaboration Services API
Owners: arbiter rdieter kkofler jreznik
Branches: F-11 F-12
InitialCC:

Comment 9 Kevin Fenzi 2009-12-09 17:43:34 UTC
cvs done.


Note You need to log in before you can comment on or make changes to this bug.