Spec URL: http://rpms.damian.net/SPECS/php-channel-swift.spec SRPM URL: http://rpms.damian.net/SRPMS/php-channel-swift-1.0.0-1.fc12.src.rpm Description: Adds swift mailer project channel to PEAR
Quick notes before review : - Requires php-cli is redundant with php-pear - replace pear.swiftmailer.org.xml by %{name}.xml (cf PHP Guidelines) I think using REST version provided (here 1.3) as version could be a good idea for this package where version have no really meaning.
(In reply to comment #1) > Quick notes before review : > - Requires php-cli is redundant with php-pear > - replace pear.swiftmailer.org.xml by %{name}.xml (cf PHP Guidelines) > > I think using REST version provided (here 1.3) as version could be a good idea > for this package where version have no really meaning. As with the other channels I got for review I just copied the one from php-channel-doctrine. Removing php-cli makes sense. I am not sure about the version number, the channel format is version 1.0 and all other php-channel-* seem to use that at the moment. It might be worth discussing that on the fedora-php list.
Note about version is only a note. There is actually no meaning to this field. I have use REST version for latest phpunit channel update, only because I think it could be usefull ;)
REVIEW * no source files (channel.xml match latest upstream) * package meets naming :( package must meet packaging guidelines * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license (of the packages provided by the channel). * license is open source-compatible (LGPLv3). * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide). * package installs properly * rpmlint (warnings are ok) : php-channel-swift.src: I: checking php-channel-swift.src:22: W: unversioned-explicit-provides php-channel(pear.swiftmailer.org) php-channel-swift.noarch: I: checking php-channel-swift.noarch: W: no-documentation php-channel-swift.spec:22: W: unversioned-explicit-provides php-channel(pear.swiftmailer.org) 2 packages and 1 specfiles checked; 0 errors, 3 warnings. * final provides are sane: php-channel(pear.swiftmailer.org) php-channel-swift = 1.0.0-1.fc8 :( final requires /usr/bin/pear php-cli php-pear(PEAR) * %check is not present; no test suite provide. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets are OK (pear channel..) * no documentation MUST - remove php-cli from Requires (already required by pear) - rename from pear.swiftmailer.org.xml to %{name}.xml (see Guildelines scriptlet sample, %{name} is the better solution to avoid any conflicts) Note (and only note) : php-channel-symfony now also use REST version as package version ;)
Spec URL: http://rpms.damian.net/SPECS/php-channel-swift.spec SRPM URL: http://rpms.damian.net/SRPMS/php-channel-swift-1.3-1.fc12.src.rpm - removed php-cli requirement, which is covered by php-pear requirement - changed name of channel xml name - using rest version as version now You convinced me on the version. I guess if they ever change the channel version the rest version will change too.
All "must" fixed ***** APPROVED *****
Oups... reply to quickly You forget to rename the XML in scriptlet. So channel is not registered after package installation.
I obviously wasn't fully awake yet. I fix the other channels too. Spec URL: http://rpms.damian.net/SPECS/php-channel-swift.spec SRPM URL: http://rpms.damian.net/SRPMS/php-channel-swift-1.3-2.fc12.src.rpm
(un)Registration of the channel is now OK. **** APPROVED ****
New Package CVS Request ======================= Package Name: php-channel-swift Short Description: Adds swift mailer project channel to PEAR Owners: cdamian Branches: F-11 F-12 InitialCC:
CVS done (by process-cvs-requests.py).
php-channel-swift-1.3-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/php-channel-swift-1.3-2.fc12
php-channel-swift-1.3-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request ====================== Package Name: php-channel-swift New Branches: EL-6 Owners: cdamian