Bug 544869 - Review Request: udunits2 - A library for manipulating units of physical quantities
Summary: Review Request: udunits2 - A library for manipulating units of physical quant...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Orion Poplawski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-12-06 20:59 UTC by Tom "spot" Callaway
Modified: 2010-01-06 23:12 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2010-01-06 23:12:31 UTC
Type: ---
Embargoed:
orion: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Tom "spot" Callaway 2009-12-06 20:59:26 UTC
Spec URL: http://www.auroralinux.org/people/spot/review/new/udunits2.spec
SRPM URL: http://www.auroralinux.org/people/spot/review/new/udunits2-2.1.11-1.fc13.src.rpm
Description: 
The Unidata units utility, udunits2, supports conversion of unit specifications
between formatted and binary forms, arithmetic manipulation of unit
specifications, and conversion of values between compatible scales of
measurement.

(NOTE: udunits v1 is already in Fedora, but v2 is incompatible in notable ways. I am the maintainer of udunits v1. We will have multiple applications dependent on both versions of udunits for the foreseeable future.)

Comment 1 Orion Poplawski 2009-12-31 17:14:47 UTC
    *  rpmlint

udunits2.i686: W: shared-lib-calls-exit /usr/lib/libudunits2.so.0.0.0 exit

A number to UCAR libraries do this - often only when a certain flag is set.  Probably worth pinging upstream about though.  Not blocking the review though.

    * naming - okay
    * NamingGuidelines
    * licensing - MIT
    * osi approved? yes
    * included? yes
    * correct mentioned in specfile? yes

specfile

    * American English - yes
    * legible - yes
    * BuildRequires - good
    * Locales - NA
    * shared libraries: ldconfig - yes
    *  %clean section with rm -rf ${RPM_BUILD_ROOT} - yes
    * macros - consistent
    * sources - checksums match upstream
    * relocatable? Prefix: /usr? - NA
    * files and directories  - good
    * owns all created directories - yes
    * all files listed in %files - yes
    * permissions? - good
    * deffattr? - yes
    * no .la files - yes
     * no conflicts with other packets - checked okay with udunits
    * -devel - yes
    * headers - yes
    * static libraries - NA
    * .so without suffix when .so.suffix existent - nope
    * .pc files - NA
    * permissable content - yes
    * doc - yes
    * large doc in -doc package - NA
    * must not affect runtime - good

    * mock build - yes
    * sane scriptlets - yes
    * subpackages with fully versioned dependency - yes

Looks good.  Approved.

Comment 2 Orion Poplawski 2010-01-06 17:55:20 UTC
New Package CVS Request
=======================
Package Name: udunits2
Short Description: A library for manipulating units of physical quantities
Owners: spot orion
Branches: F-12 F-11 EL-5 EL-4
InitialCC:

Comment 3 Tom "spot" Callaway 2010-01-06 18:00:50 UTC
Sorry for not getting to this sooner.

Comment 4 Kevin Fenzi 2010-01-06 21:38:17 UTC
cvs done.

Comment 5 Orion Poplawski 2010-01-06 23:12:31 UTC
Checked in and built.  Thanks all...


Note You need to log in before you can comment on or make changes to this bug.