Some issues:

- There is no version in the changelog - https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs
- The git checkout sha1 needs to be included in the release - see https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages
- The URL field shouldn't be the location of the source tarball, but rather a place that I can find out more about what the package does. (maybe somewhere at git-scm.org)
- The Source0 should, if possible, be a URL (all except the last element of the URL is tossed by rpmbuild) of where to download the package.  See https://fedoraproject.org/wiki/Packaging:SourceURL#Troublesome_URLs

Since Fedora 10 is no longer supported (and this will always be noarch anyways - the reason that this was in the original gitweb is that prior to F10 noarch subpackages were not supported), we can remove this from the spec:

%if 0%{?fedora} >= 10
BuildArch:      noarch
%endif

Spec file updated and new SRPM is at:

http://fedorapeople.org/~warthog9/gitweb-caching-1.6.5.2-2.cda981c9.fc12.src.rpm

1) Versions added to changelog

2) Sha1 added to release

3) URL field updated, it points to the gitweb instance since there is no other real web presence for this other than that.

4) fixed up Source0

5) setup to only build noarch instead of how it was setup.  noarch is supported by F10 and EPEL so that will work fine.

v3 is out now, documentation changes only:

http://fedorapeople.org/~warthog9/gitweb-caching-1.6.5.2-3.cda981c9.fc12.src.rpm

One more minor nitpicky thing I found doing the review - you need to include the COPYING file as %doc in the package. Provided that you do that before you import, this package is APPROVED.

Find me on IRC and I'll get you sponsored and walk you through the next steps.

OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License
OK - License field in spec matches
NO - License file included in package
YES - Spec in American English
YES - Spec is legible.
YES - Sources match upstream md5sum:
$ sha1sum --quiet -c ../sha1sums.txt 
$

Note that the tarball in the package is generated via a gitweb snapshot as mentioned in the comments
I've verified that the sha1sum of every file matches the upstream git repo

N/A - Package needs ExcludeArch
YES - BuildRequires correct
N/A - Spec handles locales/find_lang
N/A - Package is relocatable and has a reason to be.
YES - Package has %defattr and permissions on files is good.
YES - Package has a correct %clean section.
YES - Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
YES - Package is code or permissible content.
N/A - Doc subpackage needed/used.
YES - Packages %doc files don't affect runtime.

N/A - Headers/static libs in -devel subpackage.
N/A - Spec has needed ldconfig in post and postun
N/A - .pc files in -devel subpackage/requires pkgconfig
N/A - .so files in -devel subpackage.
N/A - -devel package Requires: %{name} = %{version}-%{release}
N/A - .la files are removed.

N/A - Package is a GUI app and has a .desktop file

YES - Package compiles and builds on at least one arch.
YES - Package has no duplicate files in %files.
YES - Package doesn't own any directories other packages own.
YES - Package owns all the directories it creates.
YES - No rpmlint output.
YES - final provides and requires are sane:

SHOULD Items:

YES - Should build in mock.
YES - Should build on all supported archs
YES - Should function as described.
YES - Should have sane scriptlets.
N/A - Should have subpackages require base package with fully versioned depend.
YES - Should have dist tag
YES - Should package latest version
N/A - check for outstanding bugs on package. (For core merge reviews)

Issues:

1.  Include the license file (COPYING) in the package as %doc

COPYING is now included in the spec file, re-uploaded.

New Package CVS Request
=======================
Package Name: gitweb-caching
Short Description: gitweb with an additional caching layer as run on kernel.org
Owners: warthog9
Branches: F-11 F-12 EL-5
InitialCC: warthog9

cvs done.

jgrulich's scratch build of kdevelop?#c8e2b9bc57f11e41f3dc6612cdbcc591078d9062 for f22-candidate and git://pkgs.fedoraproject.org/kdevelop?#c8e2b9bc57f11e41f3dc6612cdbcc591078d9062 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11212117

This package was approved and imported in repositories, but this review ticket was never closed.
I'm closing it now.