Bug 544996 - expat-1.95.8-CVE-2009-3560.patch breaks validation of external entity reference
Summary: expat-1.95.8-CVE-2009-3560.patch breaks validation of external entity reference
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: expat
Version: 12
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Joe Orton
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-12-07 09:35 UTC by Nathan G. Grennan
Modified: 2010-11-17 23:50 UTC (History)
3 users (show)

Fixed In Version: expat-2.0.1-8.2.fc12
Clone Of:
Environment:
Last Closed: 2010-11-17 23:27:46 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
An example nzb file (230.22 KB, application/x-nzb)
2009-12-07 09:35 UTC, Nathan G. Grennan
no flags Details
An example dtd file that goes with the example nzb file (2.00 KB, application/xml-dtd)
2009-12-07 09:36 UTC, Nathan G. Grennan
no flags Details

Description Nathan G. Grennan 2009-12-07 09:35:10 UTC
Description of problem:
  I use a piece of software called SABnzbd+. It uses uses expat to parse xml for nzb files. After upgrading to expat-2.0.1-8.fc12 from expat-2.0.1-7.fc12 I found it no longer worked properly.

 I have traced it down to expat-1.95.8-CVE-2009-3560.patch. I tried individually disabling both patches, and found only expat-1.95.8-CVE-2009-3560.patch made a difference. I also tried expat's latest cvs, and found the same error.

 I have also tried replacing the example dtd with another example dtd from W3, and get the same type of error. It doesn't seem to like %variable.


Version-Release number of selected component (if applicable):
expat-2.0.1-8.fc12.x86_64

How reproducible:
Everytime

Steps to Reproduce:
1. Download ubuntu.nzb
2. Download nzb-1.0.dtd
3. Run xmlwf -p ubuntu.nzb
  
Actual results:
nzb-1.0.dtd:30:13: syntax error
ubuntu.nzb:2:64: error in processing external entity reference

Expected results:
(No output)

Additional info:

Comment 1 Nathan G. Grennan 2009-12-07 09:35:51 UTC
Created attachment 376638 [details]
An example nzb file

Comment 2 Nathan G. Grennan 2009-12-07 09:36:44 UTC
Created attachment 376639 [details]
An example dtd file that goes with the example nzb file

Comment 3 Fedora Update System 2010-02-08 20:33:26 UTC
expat-2.0.1-8.1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/expat-2.0.1-8.1.fc12

Comment 4 Stewart Brodie 2010-07-07 16:52:22 UTC
The latest stable expat for Fedora 12 appears to still be 2.0.1-8 currently.  This contains only the broken first expat patch for CVE-2009-3560, rather than the reworked patch.

Comment 3 implies that a newer version was submitted, but I cannot find expat-2.0.1-8.1.fc12 in the updates list (the link in comment 3 doesn't work).  Should this have made it into updates?

I noticed that Fedora 13 appears to have the reworked version of the patch in expat-2.0.1-10.fc13  Please would it be possible for the same fix be pushed out for FC12, or at least the reworked patch integrated instead of the broken one?

Comment 5 Fedora Update System 2010-10-01 14:11:50 UTC
expat-2.0.1-8.2.fc12 has been submitted as an update for Fedora 12.
https://admin.fedoraproject.org/updates/expat-2.0.1-8.2.fc12

Comment 6 Joe Orton 2010-10-01 14:13:09 UTC
Sorry, this dropped off my radar.  Update now filed.

Comment 7 Fedora Update System 2010-10-05 09:36:16 UTC
expat-2.0.1-8.2.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update expat'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/expat-2.0.1-8.2.fc12

Comment 8 Joe Orton 2010-10-11 09:08:49 UTC
This update is available through updates-testing.  Please submit results of testing through the link:

https://admin.fedoraproject.org/updates/expat-2.0.1-8.2.fc12

Comment 9 Bug Zapper 2010-11-04 04:03:51 UTC
This message is a reminder that Fedora 12 is nearing its end of life.
Approximately 30 (thirty) days from now Fedora will stop maintaining
and issuing updates for Fedora 12.  It is Fedora's policy to close all
bug reports from releases that are no longer maintained.  At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '12'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 12's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 12 is end of life.  If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora please change the 'version' of this 
bug to the applicable version.  If you are unable to change the version, 
please add a comment here and someone will do it for you.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 10 Fedora Update System 2010-11-17 23:27:41 UTC
expat-2.0.1-8.2.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.