Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
For bugs related to Red Hat Enterprise Linux 5 product line. The current stable release is 5.10. For Red Hat Enterprise Linux 6 and above, please visit Red Hat JIRA https://issues.redhat.com/secure/CreateIssue!default.jspa?pid=12332745 to report new issues.

Bug 545121

Summary: possible null pointer dereference in ieee80211_change_iface
Product: Red Hat Enterprise Linux 5 Reporter: John W. Linville <linville>
Component: kernelAssignee: John W. Linville <linville>
Status: CLOSED ERRATA QA Contact: Red Hat Kernel QE team <kernel-qe>
Severity: urgent Docs Contact:
Priority: low    
Version: 5.5CC: cmeadors, dzickus, kernel-mgr, rlerch
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-03-30 07:44:36 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 526948    
Attachments:
Description Flags
jwltest-ieee80211_change_iface-avoid-null-deref.patch
none
jwltest-wireless-2_6_32-kill-some-warnings.patch
none
jwltest-cfg80211-extras.patch none

Description John W. Linville 2009-12-07 16:33:42 UTC
Created attachment 376724 [details]
jwltest-ieee80211_change_iface-avoid-null-deref.patch

CC [M]  net/mac80211/cfg.o
net/mac80211/cfg.c: In function `ieee80211_change_iface':
net/mac80211/cfg.c:74: warning: 'sdata' might be used uninitialized in this function

Comment 1 John W. Linville 2009-12-07 16:36:53 UTC
Created attachment 376726 [details]
jwltest-wireless-2_6_32-kill-some-warnings.patch

Missed the warning for the uninitialized variable due to warning SPAM leftover from some earlier hacking.  This patch gets rid of that to help avoid doing that again...

Comment 2 John W. Linville 2009-12-07 16:38:50 UTC
Created attachment 376728 [details]
jwltest-cfg80211-extras.patch

A bit of a stretch, but vaguely related since you could/would hit the original problem by switching modes, one of the main reasons to switch modes is for monitoring, and this patch enables you to add monitoring interfaces instead... :-)

Comment 3 RHEL Program Management 2009-12-07 16:53:12 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 6 Don Zickus 2009-12-15 20:19:51 UTC
in kernel-2.6.18-181.el5
You can download this test kernel from http://people.redhat.com/dzickus/el5

Please update the appropriate value in the Verified field
(cf_verified) to indicate this fix has been successfully
verified. Include a comment with verification details.

Comment 10 Cameron Meadors 2010-01-27 19:34:27 UTC
change to VERIFIED

Checked build logs for warnings on kernel-2.6.18-185.el5.  No null dereferences when using very small sampling of wireless devices.  Since we didn't see that many before, that is good enough.

Comment 12 errata-xmlrpc 2010-03-30 07:44:36 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2010-0178.html