Bug 545121 - possible null pointer dereference in ieee80211_change_iface
Summary: possible null pointer dereference in ieee80211_change_iface
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: kernel
Version: 5.5
Hardware: All
OS: Linux
low
urgent
Target Milestone: rc
: ---
Assignee: John W. Linville
QA Contact: Red Hat Kernel QE team
URL:
Whiteboard:
Depends On:
Blocks: 526948
TreeView+ depends on / blocked
 
Reported: 2009-12-07 16:33 UTC by John W. Linville
Modified: 2010-03-30 07:44 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-03-30 07:44:36 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
jwltest-ieee80211_change_iface-avoid-null-deref.patch (386 bytes, patch)
2009-12-07 16:33 UTC, John W. Linville
no flags Details | Diff
jwltest-wireless-2_6_32-kill-some-warnings.patch (3.08 KB, patch)
2009-12-07 16:36 UTC, John W. Linville
no flags Details | Diff
jwltest-cfg80211-extras.patch (1.75 KB, patch)
2009-12-07 16:38 UTC, John W. Linville
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2010:0178 0 normal SHIPPED_LIVE Important: Red Hat Enterprise Linux 5.5 kernel security and bug fix update 2010-03-29 12:18:21 UTC

Description John W. Linville 2009-12-07 16:33:42 UTC
Created attachment 376724 [details]
jwltest-ieee80211_change_iface-avoid-null-deref.patch

CC [M]  net/mac80211/cfg.o
net/mac80211/cfg.c: In function `ieee80211_change_iface':
net/mac80211/cfg.c:74: warning: 'sdata' might be used uninitialized in this function

Comment 1 John W. Linville 2009-12-07 16:36:53 UTC
Created attachment 376726 [details]
jwltest-wireless-2_6_32-kill-some-warnings.patch

Missed the warning for the uninitialized variable due to warning SPAM leftover from some earlier hacking.  This patch gets rid of that to help avoid doing that again...

Comment 2 John W. Linville 2009-12-07 16:38:50 UTC
Created attachment 376728 [details]
jwltest-cfg80211-extras.patch

A bit of a stretch, but vaguely related since you could/would hit the original problem by switching modes, one of the main reasons to switch modes is for monitoring, and this patch enables you to add monitoring interfaces instead... :-)

Comment 3 RHEL Program Management 2009-12-07 16:53:12 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 6 Don Zickus 2009-12-15 20:19:51 UTC
in kernel-2.6.18-181.el5
You can download this test kernel from http://people.redhat.com/dzickus/el5

Please update the appropriate value in the Verified field
(cf_verified) to indicate this fix has been successfully
verified. Include a comment with verification details.

Comment 10 Cameron Meadors 2010-01-27 19:34:27 UTC
change to VERIFIED

Checked build logs for warnings on kernel-2.6.18-185.el5.  No null dereferences when using very small sampling of wireless devices.  Since we didn't see that many before, that is good enough.

Comment 12 errata-xmlrpc 2010-03-30 07:44:36 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2010-0178.html


Note You need to log in before you can comment on or make changes to this bug.