Bug 545272 - AX-25-tools All builds are bad
Summary: AX-25-tools All builds are bad
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: ax25-tools
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Randy Berry
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-12-08 01:08 UTC by Michael Schwendt
Modified: 2011-07-16 07:26 UTC (History)
5 users (show)

Fixed In Version: ax25-tools-0.0.9-6.fc15
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-07-16 07:25:15 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Michael Schwendt 2009-12-08 01:08:35 UTC
The package "BuildRequires: fltk-devel" but fails at compiling/linking with fltk. No mention of libfltk in the build logs and no dependency on libfltk.so.1.1 either.

For example:

  http://koji.fedoraproject.org/koji/buildinfo?buildID=116358

Build log:

  checking for main in -lGL... no
  checking for main in -lMesaGL... no

Expected build log:

  checking for main in -lGL... yes
  checking for main in -lfltk... yes

Also query the binary rpms to see that fltk is missing.

Comment 1 Bug Zapper 2010-11-04 03:58:42 UTC
This message is a reminder that Fedora 12 is nearing its end of life.
Approximately 30 (thirty) days from now Fedora will stop maintaining
and issuing updates for Fedora 12.  It is Fedora's policy to close all
bug reports from releases that are no longer maintained.  At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '12'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 12's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 12 is end of life.  If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora please change the 'version' of this 
bug to the applicable version.  If you are unable to change the version, 
please add a comment here and someone will do it for you.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 2 Fedora Admin XMLRPC Client 2011-06-20 22:44:43 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 3 Randy Berry 2011-06-21 06:22:00 UTC
I'll be honest, I haven't a clue how to fix this. Any advice Michael?

Comment 4 Michael Schwendt 2011-06-21 08:40:29 UTC
1) Have you even tried to reproduce the problem on a recent Fedora release? A local build on F15 manages to link with FLTK at least while the one linked in the bug report didn't.

2) If the spec "BuildRequires: fltk-devel", is this because FLTK is wanted? If so, try to fix the configure check, or add a guard in the spec that makes sure the build fails if FLTK isn't detected.

Comment 5 Randy Berry 2011-06-22 00:01:27 UTC
Yes, I tried several mock local builds in various forms even scratch builds on koji last night and on koji again today and I still get:

checking for main in -lGL... no
checking for main in -lMesaGL... no

Even after adding mesa-libGL-devel to the BRs I still get

checking for main in -lGL... no
checking for main in -lMesaGL... no

and I don't see 'checking for main in -lfltk...' anywhere

I even removed fltk-devel from BuildRequires and it still builds.

I don't understand why the configure file is checking for fltk if it isn't required, and if it is required why is it building without it?

I also don't understand why GL would be required, this is a back end application that has no GUI, but for some reason the configure file checks for it.

F14 Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3151576
F15 Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3151265

I'm totally confused.

Comment 6 Michael Schwendt 2011-06-22 08:49:49 UTC
Hey, that's why I filed this ticket. ;)

Meanwhile:

  $ rpm -qpR ax25-tools-0.0.9-3.fc15.x86_64.rpm | grep libGL
  libGL.so.1()(64bit)  

  $ rpm -qpR ax25-tools-0.0.9-3.fc15.x86_64.rpm | grep -i fltk
  libfltk.so.1.1()(64bit)  

That's the current state with a local F15 build. In the source code you can find comments related to FLTK, btw, and examine where it is used. e.g. in ax25-tools/hdlcutil/fl/:

  $ grep Fl_ *|wc -l
  446

As the package maintainer, you would find out whether building with FLTK is desired and how to take precautions to make the build results consistent.

Comment 7 Ralf Baechle 2011-06-24 22:20:28 UTC
The reason for libGL not being found is that the autoconf script tries to link -lGL -lXi and a few more libs when probing for libGL.  Only if fltk-devel and libXi-devel are installed hdlcutil/fl/ will be built resulting in 4 binaries that have dependencies on loads of X libraries.

That's a bit of a trap to the unwitting user so I added a BuildRequires to the spec file in the CVS repository.  See http://www.linux-ax25.org/cvsweb/ax25-tools/ax25-tools.spec.in.diff?r1=1.1;r2=1.2

Comment 8 Randy Berry 2011-06-25 02:05:12 UTC
Thanks Ralf, 

All fixed. Build.log now reports properly.


checking for main in -lGL... yes
checking for main in -lfltk... yes

http://koji.fedoraproject.org/koji/taskinfo?taskID=3159847

Comment 9 Fedora Update System 2011-06-25 02:09:42 UTC
ax25-tools-0.0.9-6.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/ax25-tools-0.0.9-6.fc15

Comment 10 Fedora Update System 2011-06-25 02:29:59 UTC
ax25-tools-0.0.9-6.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/ax25-tools-0.0.9-6.fc14

Comment 11 Ralf Baechle 2011-06-25 13:27:52 UTC
With this change the installation of the ax25-tools rpm will pull in lots of X libraries via dependencies.  To solve that I've just split the rpm into two packages, ax25-tools and ax25-toolsx in the spec file in CVS.  As you may guess the latter package contains all the tools that depend on X11 which are smdiag, xfhdlcchpar, xfhdlcst, xfsmdiag and xfsmmixer.

Comment 12 Fedora Update System 2011-06-25 19:59:20 UTC
Package ax25-tools-0.0.9-6.fc14:
* should fix your issue,
* was pushed to the Fedora 14 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing ax25-tools-0.0.9-6.fc14'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/ax25-tools-0.0.9-6.fc14
then log in and leave karma (feedback).

Comment 13 Fedora Update System 2011-07-16 07:25:06 UTC
ax25-tools-0.0.9-6.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2011-07-16 07:26:45 UTC
ax25-tools-0.0.9-6.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.