Bug 545279 - mozplugger configuration file errors out if acroread is absent
mozplugger configuration file errors out if acroread is absent
Product: Fedora
Classification: Fedora
Component: mozplugger (Show other bugs)
All Linux
low Severity medium
: ---
: ---
Assigned To: Ngo Than
Fedora Extras Quality Assurance
Depends On:
  Show dependency treegraph
Reported: 2009-12-07 20:53 EST by Michal Jaegermann
Modified: 2010-09-29 08:05 EDT (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2010-09-29 08:05:30 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description Michal Jaegermann 2009-12-07 20:53:14 EST
Description of problem:

/etc/mozpluggerrc is run through m4 and contains the following code:

# Trap only version 5 assume the rest work OK (6 onwards...)
ifelse(esyscmd([acroread -v | grep "^[^0-9]*5\..*$"]), [], [
  define(ACROREAD, [ACROREAD_FLAGS() : acroread ACROREAD_OPTS() "$file"])
  define(ACROREAD, [ACROREAD_FLAGS5() : acroread ACROREAD_OPTS5() "$file"])

If acroread happens NOT to be present on an installation this results in the following error: "sh: acroread: command not found" and on occasions takes a long while to get there.

That really checks for an ancient version of acroread which nobody should use anymore if only for security reasons; so all the above could be really replaced by:

define(ACROREAD, [ACROREAD_FLAGS() : acroread ACROREAD_OPTS() "$file"])

Switching positions of evince and acroread in a PDF block of /etc/mozpluggerrc would make also less likely that somebody with an antique on hands will hit it when using mozplugger even if options are "wrong".

Version-Release number of selected component (if applicable):

How reproducible:
always without acroread in PATH
Comment 1 Michal Jaegermann 2009-12-09 13:13:34 EST
If you are reluctant to cause difficulties even for those with a long obsolete version of acroread then instead of 'acroread -v' in esyscmd the following will work surely better regardless of what kind of a shell is in use:

   bash -c "type -p acroread >/dev/null && acroread -v"
Comment 2 Ngo Than 2010-09-29 08:05:30 EDT
it should be fixed in mozplugger-1.14.2-1.fc13 which will be available in f13-update-testing soon. Or you can download it from http://koji.fedoraproject.org/koji/buildinfo?buildID=189076

Note You need to log in before you can comment on or make changes to this bug.