Bug 545452 - PrinterAdd call thinks ppd-name is mandatory
Summary: PrinterAdd call thinks ppd-name is mandatory
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: cups-pk-helper
Version: 12
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Marek Kašík
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-12-08 16:00 UTC by Tim Waugh
Modified: 2010-01-07 00:54 UTC (History)
1 user (show)

Fixed In Version: 0.0.4-10.fc12
Clone Of:
Environment:
Last Closed: 2010-01-07 00:54:30 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
cups-pk-helper-add-printer-ppd-optional.patch (949 bytes, patch)
2009-12-08 16:00 UTC, Tim Waugh
no flags Details | Diff

Description Tim Waugh 2009-12-08 16:00:41 UTC
Created attachment 376930 [details]
cups-pk-helper-add-printer-ppd-optional.patch

Description of problem:
The PrinterAdd implementation thinks that ppd-name is a mandatory parameter but I don't think it should be.  The underlying CUPS-Add-Modify-Printer call does not require it.

System-config-printer uses addPrinter(name, device=...), and this fails.

Version-Release number of selected component (if applicable):
cups-pk-helper-0.0.4-9.fc12.x86_64

How reproducible:
100%

Steps to Reproduce:
1.Just change the device of a printer.
  
Actual results:
PolicyKit call fails, IPP authentication dialog presented.

Expected results:
PolicyKit call succeeds.

Comment 1 Marek Kašík 2009-12-10 17:33:40 UTC
Hi Tim,

thank you for the patch. I committed it (it is cups-pk-helper-0.0.4-10.fc12).

Marek

Comment 2 Fedora Update System 2009-12-10 17:34:38 UTC
cups-pk-helper-0.0.4-10.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/cups-pk-helper-0.0.4-10.fc12

Comment 3 Fedora Update System 2009-12-11 18:38:21 UTC
cups-pk-helper-0.0.4-10.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update cups-pk-helper'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2009-13144

Comment 4 Fedora Update System 2010-01-07 00:54:26 UTC
cups-pk-helper-0.0.4-10.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.