Bug 545987 - gkrelmm crashes on dead bateries
Summary: gkrelmm crashes on dead bateries
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: gkrellm
Version: 12
Hardware: i686
OS: Linux
low
medium
Target Milestone: ---
Assignee: Hans de Goede
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: abrt_hash:fc69b93630144ec94daee011d2b...
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-12-09 18:49 UTC by Stuart D Gathman
Modified: 2009-12-28 20:12 UTC (History)
3 users (show)

Fixed In Version: 2.3.3-1.fc11
Clone Of:
Environment:
Last Closed: 2009-12-28 20:06:23 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
File: backtrace (5.36 KB, text/plain)
2009-12-09 18:49 UTC, Stuart D Gathman
no flags Details

Description Stuart D Gathman 2009-12-09 18:49:34 UTC
abrt 1.0.0 detected a crash.

How to reproduce
-----
1.Invoke from menu
2.
3.

Comment
-----
Since the stacktrace shows the fault in gkrellm_init_battery_monitor(), I suspect it has to do with the fact that the battery is dead on this machine.  aciptool shows:
  Battery #1     : charging, -nan%, 00:00:00

Gkrellm needs a divide by zero check or similar.

Attached file: backtrace
cmdline: gkrellm
component: gkrellm
executable: /usr/bin/gkrellm
kernel: 2.6.31.6-162.fc12.i686
package: gkrellm-2.3.2-7.fc12
rating: 3
reason: Process was terminated by signal 6

Comment 1 Stuart D Gathman 2009-12-09 18:49:36 UTC
Created attachment 377267 [details]
File: backtrace

Comment 2 Hans de Goede 2009-12-16 11:15:36 UTC
Thanks for the bug report, this certainly looks fixable, unfortunately I don't have time to look in to this right now, I'll keep this on my to do list.

Comment 3 Hans de Goede 2009-12-20 13:56:57 UTC
I think I have a fix for this, expect a gkrellm update soon. Please let me know of that update fixes things for you.

Comment 4 Stuart D Gathman 2009-12-20 21:18:41 UTC
I saved the dead battery just for you!

Comment 5 Hans de Goede 2009-12-21 10:24:55 UTC
(In reply to comment #4)
> I saved the dead battery just for you!  

Thanks,

Could you please test the updated packages with the dead battery and let me know if the update fixes the crash ?

Regards,

Hans

Comment 6 Fedora Update System 2009-12-22 04:42:44 UTC
gkrellm-2.3.2-8.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update gkrellm'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2009-13436

Comment 7 Fedora Update System 2009-12-22 08:41:11 UTC
gkrellm-2.3.3-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/gkrellm-2.3.3-1.fc12

Comment 8 Fedora Update System 2009-12-22 08:42:26 UTC
gkrellm-2.3.3-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/gkrellm-2.3.3-1.fc11

Comment 9 Fedora Update System 2009-12-22 19:54:50 UTC
gkrellm-2.3.3-1.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update gkrellm'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2009-13542

Comment 10 Fedora Update System 2009-12-22 19:55:54 UTC
gkrellm-2.3.3-1.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update gkrellm'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-13555

Comment 11 Stuart D Gathman 2009-12-27 01:15:59 UTC
I reinstalled the dead battery, loaded the update from testing (with A/C connected :), and verified that the bug is fixed.  No crash despite the battery being at 0%.  I enabled the battery monitor, and it shows 0% which is reasonable (although since the battery holds 0 charge, the % is technically undefined, and the acpitool output of NaN is also good).  I hibernated, reinstalled the new battery, and it still runs and shows the proper battery percentage.  I haven't noticed anything else breaking, but I've only played with the new version for a few minutes.

Good job!

Comment 12 Hans de Goede 2009-12-27 08:46:47 UTC
Thanks for testing!

Comment 13 Fedora Update System 2009-12-28 20:06:06 UTC
gkrellm-2.3.3-1.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2009-12-28 20:12:32 UTC
gkrellm-2.3.3-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.