http://cvs.fedoraproject.org/viewvc/devel/kasumi/ We missed the merge review for kasumi somehow, guess because of Bug#165778 and/or Bug#165779, which apparently hasn't been done the certain reviews. so we need to revisit to ensure it's better.
Some remarks * BR - Please check if gettext"-devel" is really needed for BR - Also "BR: automake autoconf" don't seem to be needed because no autotools are called during build. * SourceURL - I guess the following works. http://dl.sourceforge.jp/kasumi/41436/kasumi-2.5.tar.gz * %makeinstall - Please avoid to use %makeinstall and use "make install DESTDIR=$RPM_BUILD_ROOT" instead https://fedoraproject.org/wiki/Packaging/Guidelines#Why_the_.25makeinstall_macro_should_not_be_used ! and consider to add 'INSTALL="install -p"' to "make install" to keep timestamps on installed files as much as possible. ? Removing desktop ----------------------------------------------------------- # remove .desktop file so that kasumi is accessible from # scim panel and it's not necessary for other users. rm -rf $RPM_BUILD_ROOT%{_datadir}/applications/*.desktop ----------------------------------------------------------- - Is this also true for people using ibus (as now we use ibus by default) and some other input method (such as uim/uim-anthy)? - Does this mean that %_datadir/pixmaps/kasumi.png can also be removed? * Misc rpmlint issues ----------------------------------------------------------- kasumi.i686: W: summary-ended-with-dot C An anthy dictionary management tool. ----------------------------------------------------------- - Please fix above.
Thanks for the review. I should do self-review before submitting this ;) (In reply to comment #1) > Some remarks > > * BR > - Please check if gettext"-devel" is really needed for BR > - Also "BR: automake autoconf" don't seem to be needed because > no autotools are called during build. No they aren't needed. fixed. > * SourceURL > - I guess the following works. > http://dl.sourceforge.jp/kasumi/41436/kasumi-2.5.tar.gz Aha. it didn't work before IIRC. so that might be improved at sf.jp then :) cool. fixed. > * %makeinstall > - Please avoid to use %makeinstall and use "make install > DESTDIR=$RPM_BUILD_ROOT" > instead fixed. > ? Removing desktop > ----------------------------------------------------------- > # remove .desktop file so that kasumi is accessible from > # scim panel and it's not necessary for other users. > rm -rf $RPM_BUILD_ROOT%{_datadir}/applications/*.desktop > ----------------------------------------------------------- > - Is this also true for people using ibus (as now we use > ibus by default) and some other input method (such as uim/uim-anthy)? > - Does this mean that %_datadir/pixmaps/kasumi.png can also > be removed? added it back. ideally ibus-anthy should supports it as scim-anthy does and get rid of it from the menu after that, but anyway. > * Misc rpmlint issues > ----------------------------------------------------------- > kasumi.i686: W: summary-ended-with-dot C An anthy dictionary management tool. > ----------------------------------------------------------- > - Please fix above. fixed. please revisit the CVS again for confirming.
Checked kasumi.spec rev 1.34 (In reply to comment #2) > > ? Removing desktop added it back. ideally ibus-anthy should supports it as scim-anthy does and get > rid of it from the menu after that, but anyway. Then now please use desktop-file-{install,validate} https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files By the way - "Application" in Category is deprecated and should be removed: http://www.redhat.com/archives/fedora-extras-list/2006-October/msg00723.html - It is better that "Icon=kasumi" instead of using "Icon=kasumi.png"
(In reply to comment #2) > added it back. ideally ibus-anthy should supports it as scim-anthy does and get > rid of it from the menu after that, but anyway. Please file a bug.
(In reply to comment #1) > * SourceURL > - I guess the following works. > http://dl.sourceforge.jp/kasumi/41436/kasumi-2.5.tar.gz FWIW I just had a chance to talk about this with OSDN guy though, starting a download with the above URL isn't expected behaviour it seems. I'll revert this change because it may be changed in the future and safe to access the mirror site directly. (In reply to comment #3) > Then now please use desktop-file-{install,validate} > https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files > > By the way > - "Application" in Category is deprecated and should be removed: > http://www.redhat.com/archives/fedora-extras-list/2006-October/msg00723.html > - It is better that "Icon=kasumi" instead of using "Icon=kasumi.png" All the above fixed in CVS.
(In reply to comment #4) > (In reply to comment #2) > > added it back. ideally ibus-anthy should supports it as scim-anthy does and get > > rid of it from the menu after that, but anyway. > > Please file a bug. Well, how should I think of desktop file for now?
(In reply to comment #6) > Well, how should I think of desktop file for now? I think reverting the desktop file in the rpm would be a workaround. It's a problem when a language specific tool is shown on other language menu items. It would be better to remove the .desktop file after ibus-anthy language bar could show the menu. That's why I asked to file a bug in ibus-anthy.
(In reply to comment #7) > (In reply to comment #6) > > Well, how should I think of desktop file for now? > > I think reverting the desktop file in the rpm would be a workaround. > It's a problem when a language specific tool is shown on other language menu > items. > It would be better to remove the .desktop file after ibus-anthy language bar > could show the menu. > That's why I asked to file a bug in ibus-anthy. Filed as bug 550001
Created attachment 384540 [details] screenshot of ibus / ibus-anthy / kasumi Now kasumi can be accessible from ibus-anthy (as screenshot attached). Tagoh-san, would you remove kasumi.desktop again? (/usr/share/pixmaps/kasumi.png is hardcoded in ibus-anthy so it seems that kasumi.png cannot be deleted).
What is the status of this bug?
Ah, sorry. I missed that. fixed in CVS.
Looks good. Please fix the release number (Release: line says it is -2, %changelog says -3) and actually rebuild on koji for F-14/13.
Oops. done for both branches.
Thank you. Now for F-13 would you submit the rebuilt one to bodhi?
kasumi-2.5-3.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/kasumi-2.5-3.fc13
Yep. thanks for reminding. done :)
Thank you. Now closing.
kasumi-2.5-3.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request ====================== Package Name: kasumi New Branches: epel7 Owners: tagoh InitialCC: i18n-team
Git done (by process-git-requests).