Bug 546212 - (panner2html) Review Request: planner2html - convert planner files to html
Review Request: planner2html - convert planner files to html
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Fabian Affolter
Fedora Extras Quality Assurance
:
: 546178 (view as bug list)
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2009-12-10 07:34 EST by Caolan McNamara
Modified: 2009-12-21 15:41 EST (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-12-21 15:41:16 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
mail: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Caolan McNamara 2009-12-10 07:34:42 EST
Spec URL: http://people.redhat.com/caolanm/rpms/planner2html.spec
SRPM URL: http://people.redhat.com/caolanm/rpms/planner2html-1.0.0-1.fc12.src.rpm
Description: Command line utility to convert planner files to html
Comment 1 Caolan McNamara 2009-12-10 07:38:06 EST
*** Bug 546178 has been marked as a duplicate of this bug. ***
Comment 2 Fabian Affolter 2009-12-21 05:56:00 EST
Package Review
==============

Package: 

Key:
 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [x] Package is named according to the Package Naming Guidelines
 [x] Spec file name must match the base package %{name}, in the format %{name}.spec
 [x] Package meets the Packaging Guidelines
 [x] Package successfully compiles and builds into binary RPMs on at least one
supported architecture
     Tested on: F12/i386
 [!] Rpmlint output:
     Source RPM:
     [fab@localhost SRPMS]$ rpmlint planner2html-1.0.0-1.fc12.src.rpm 
     1 packages and 0 specfiles checked; 0 errors, 0 warnings.
     Binary RPM(s):
     planner2html-debuginfo.i686: E: debuginfo-without-sources
     2 packages and 0 specfiles checked; 1 errors, 0 warnings.
 [x] Package is not relocatable
 [x] Buildroot is correct
     master   : %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
     spec file: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license
     License type: GPLv2+
 [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc

 [x] Spec file is legible and written in American English
 [x] Sources used to build the package matches the upstream source, as provided
in the spec URL
     Upstream source: de94e1fdd70eb35f9f8baf0aa521f53c
     Build source:    de94e1fdd70eb35f9f8baf0aa521f53c
 [x] Package is not known to require ExcludeArch
 [-] Architecture independent packages have: BuildArch: noarch
 [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.  %find_lang used for locales
 [!] %{optflags} or RPM_OPT_FLAGS are honoured
 [-] ldconfig called in %post and %postun if required
 [x] %install starts with rm -rf %{buildroot} or $RPM_BUILD_ROOT
 [x] Package must own all directories that it creates
 [x] Package requires other packages for directories it uses
 [x] Package does not own files or directories owned by other packages
 [x] Package does not contain duplicates in %files
 [x] Permissions on files are set properly. %defattr(-,root,root,-) is in every %files section
 [x] Package uses nothing in %doc for runtime
 [x] Package has a %clean section, which contains rm -rf %{buildroot} or $RPM_BUILD_ROOT
 [-] Included tests passed successfully 
 [x] Package consistently uses macros
 [x] Package contains code, or permissable content
 [x] Included filenames are in UTF-8

 [-] Large documentation files are in a -doc subpackage, if required
 [-] Header files (.h) in -devel subpackage, if present
 [-] Fully versioned dependency in subpackage, if present
 [-] Static libraries (.a) in -static subpackage, if present
 [-] Package requires pkgconfig, if .pc files are present
 [-] Development .so files in -devel subpackage, if present
 [-] Package does not contain any libtool archives (.la)
 [!] -debuginfo subpackage is present and looks complete
 [-] No pre-built binaries (.a, .so*, executable)
 
 [-] Package contains a properly installed .desktop file if it is a GUI application
 [-] Follows desktop entry spec
 [-] Valid .desktop Name
 [-] Valid .desktop GenericName
 [-] Valid .desktop Categories
 [-] Valid .desktop StartupNotify
 [-] .desktop file installed with desktop-file-install in %install

=== SUGGESTED ITEMS ===
 [!] Timestamps preserved with cp and install
 [!] Uses parallel make (%{?_smp_mflags})
 [x] Latest version is packaged
 [x] Package does not include license text files separate from upstream
 [-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available
 [x] Reviewer should test that the package builds in mock
     Tested on: F12/i386
 [x] Package should compile and build into binary RPMs on all supported
architectures.
     Tested:  http://koji.fedoraproject.org/koji/taskinfo?taskID=1882804
 [x] Package functions as described
 [-] Scriptlets must be sane, if used
 [-] The placement of pkgconfig(.pc) files is correct
 [-] File based requires are sane
 [x] Changelog in allowed format

Please the issues and I will be happy to approve this package.
Comment 3 Caolan McNamara 2009-12-21 07:34:55 EST
http://people.redhat.com/caolanm/rpms/planner2html.spec
http://people.redhat.com/caolanm/rpms/planner2html-1.0.0-2.fc12.src.rpm

- Honours RPM_OPT_FLAGS (which also fixes debuginfo)
- Use parallel make, only one source file, but doesn't hurt of course
- Timestamps preserved with install -p
Comment 4 Fabian Affolter 2009-12-21 09:46:10 EST
Your way with the compiler flags is a bit unusual for me.  I'm more familiar with just 'make %{?_smp_mflags} CFLAGS="%{optflags}"'.  But this is your call.


I see no further blocker, package APPROVED
Comment 5 Caolan McNamara 2009-12-21 10:41:41 EST
New Package CVS Request
=======================
Package Name: planner2html
Short Description: Convert planner files to html
Owners: caolanm
Branches: F-12 devel
InitialCC:
Comment 6 Kevin Fenzi 2009-12-21 14:39:45 EST
cvs done.

Note You need to log in before you can comment on or make changes to this bug.