Spec URL: http://allisson.fedorapeople.org/packages/python-whoosh/python-whoosh.spec SRPM URL: http://allisson.fedorapeople.org/packages/python-whoosh/python-whoosh-0.3.9-1.fc12.src.rpm Description: Whoosh is a fast, featureful full-text indexing and searching library implemented in pure Python. Whoosh was created and is maintained by MattChaput. It was originally created for use in the online help system of Side Effects Software's 3D animation software Houdini. Side Effects Software Inc. graciously agreed to open-source the code. Some of Whoosh's features include: Pythonic API. Pure-Python. No compilation or binary packages needed, no mysterious crashes. Fielded indexing and search. Fast indexing and retrieval -- faster than any other pure-Python, scoring, full-text search solution I know of. Pluggable scoring algorithm (including BM25F), text analysis, storage, posting format, etc. Powerful query language parsed by pyparsing. Pure Python spell-checker (as far as I know, the only one). Whoosh might be useful in the following circumstances: Anywhere a pure-Python solution is desirable to avoid having to build/compile native libraries (or force users to build/compile them). As a research platform (at least for programmers that find Python easier to read and work with than Java ;) When an easy-to-use Pythonic interface is more important to you than raw speed. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1870135
Review: Good: - name ok - using macros - buildroot ok - rpmlint clean - %clean section is there - permissions ok - %files section ok - arch ok - no .la files - no libs - no desktop file needed - builds in koji NEEDSWORK: - description is bad: If you do a 'yum search Java' you'll get this package, which has nothing to do with java... in PKG-INFO is: Whoosh is a fast, pure-Python indexing and search library. Programmers can use it to easily add search functionality to their applications and websites. Because Whoosh is pure Python, you don't have to compile or install a binary support library and/or make Python work with a JVM, yet Whoosh is still very fast at indexing and searching. Every part of how Whoosh works can be extended or replaced to meet your needs exactly. How about that? - BR wrong: please require only python-setuptools and not python-setuptools-devel - You should query upstream to include a license.txt or COPYING file. It's referenced in PKG-INFO, but nowhere to find.
Update package: Spec URL: http://allisson.fedorapeople.org/packages/python-whoosh/python-whoosh.spec SRPM URL: http://allisson.fedorapeople.org/packages/python-whoosh/python-whoosh-0.3.9-2.fc12.src.rpm Changelog - Fix BR. - Copy LICENSE.txt from svn to include in rpm. - Fix description
See: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text Please delete the LICENSE.txt file again. Upstream *should* include it, if you email them and they say 'no' - that's ok. You only need to mail them, and that's it.
There is a new version 0.3.18, could you please update? The URL is now wrong, because upstream uses now bitbucket: http://bitbucket.org/mchaput/whoosh/wiki/Home There should not arise a new problem for this to get approved...
Ping, are you still interessted in packaging this?
Hi, i'll make a update soon. And yes, i interessted in packaging this. Regards, Allisson.
Another ping...
I've created a separate spec (didn't see this review until I was about to submit a review request), it looks like this review is probably stalled. Allisson please respond to this ticket within a week otherwise I'm going to close this ticket as dead and submit a new review. http://fedoraproject.org/wiki/Extras/Policy/StalledReviews#Submitter_not_responding If you're still interested in maintaining this package you're welcome to grab my spec (you're missing at least the licensing stuff and check section). SPEC: https://github.com/silas/rpms/raw/master/python-whoosh/python-whoosh.spec
@Silas: You should open your review request. Closing.