Red Hat Bugzilla – Bug 54851
Incorrect change to parameters for kallsyms_address_to_symbol()
Last modified: 2007-04-18 12:37:41 EDT
From Bugzilla Helper:
User-Agent: Mozilla/4.76 [en] (X11; U; Linux 2.4.10-pre8-xfs i586)
Description of problem:
In kallsyms.c and kallsyms.h, somebody has removed the 'const' keyword from
parameters mod_name, sec_name and sym_name to
kallsyms_address_to_symbol(). The 'const' was there for a very good
reason, the caller is given a pointer into the global kallsyms data and
they must *NOT* change the data referenced by the pointer. Put
kallsyms_address_to_symbol() back the way I wrote it and change the caller
to pass correct parameters.
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1. Look at the code the way it was originally written.
I'll grab the fixed version from the SGI hacked RHL7.2 when SGI releases that
The SGI update just reinstates the original kallsyms.[ch] from the kdb patch. I
did not change kksymoops.c which is where the real problem is, that is not my
code. Whoever wrote kksymoops needs to get their code right. Please do not
wait for SGI update to RH, back out the kallsyms changes now.
Fixed in yesterdays errata