Bug 548851 - dnssec-conf v1.22-1.fc13 causes unacceptable layout and format changes to resulting named.conf
Summary: dnssec-conf v1.22-1.fc13 causes unacceptable layout and format changes to res...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: dnssec-conf
Version: 13
Hardware: All
OS: Linux
low
high
Target Milestone: ---
Assignee: Paul Wouters
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: dnssecmods
TreeView+ depends on / blocked
 
Reported: 2009-12-18 20:24 UTC by John 'Warthog9' Hawley
Modified: 2010-08-26 18:29 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-08-26 18:29:55 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description John 'Warthog9' Hawley 2009-12-18 20:24:50 UTC
Description of problem:

In an attempt to get a dnssec-conf package that did not cause bug#505754 I went ahead and upgraded to the dnssec-conf that's present in rawhide (I'm currently running Fedora 11).

While this *DID* fix the issue found in bug#505754, it however caused massive formatting and structural changes to the named.conf file in question.  It removed whitespace that was there on purpose, changed comment structuring, added extraneous blocks, etc.

My original named.conf file was 486 lines long, had a readable formatting and was easily understood

The new Named file is 501 lines long and has the formatting completely changed and made nigh unreadable.

The patch difference between the two results in a uniform (-u) diff of 629 lines long.

Examples 1 changes:
-------------------------------------------------------------------------------
-               127.0.0.1;                      # localhost
-               149.20.20.144;                  # ns2.kernel.org (odin1) - new - san jose
+               127.0.0.1;
+               
+                       # localhost
+               149.20.20.144;
+               
+                       # ns2.kernel.org (odin1) - new - san jose
...

Example 2 changes:
-------------------------------------------------------------------------------
 };
-
 // reduce log verbosity on issues outside our control
 logging {
-       category lame-servers { null; };        # Not interested in lame remote servers
-       category resolver { null; };            # Not interested in broken remote servers
-       category lame-servers { null; };        # Not interested in brokenness
+       category lame-servers {
+               null;
+       };
+       
+               # Not interested in lame remote servers
+       category resolver {

-------------------------------------------------------------------------------

It was bad enough that dnssec-conf couldn't properly patch named.conf but the new version is blatantly unacceptable for these huge changes and what with bind now *REQUIRING* it

# rpm -q --requires bind | grep dnssec-conf
dnssec-conf  
#

it's a little difficult to just remove this and ignore dnssec for the time being, or manually add the dnssec information on our own and not use dnssec-conf

Version-Release number of selected component (if applicable):

1.22-1.fc13

How reproducible:

Always

Steps to Reproduce:
1. have named.conf
2. start named or run dnssec-configure
3. named.conf has been massively altered.
  
Actual results:

hugely reformatted named.conf file.

Expected results:

minimal changes to add *only* the required information for dnssec-conf.  The version from F11 / F12 came closer, it just screwed up on where it added the entries if you have a reasonably complex dns structure.

Comment 1 Oron Peled 2010-02-09 22:18:57 UTC
cross-reference:
 I attached to bug 505754 a minimal patch that prevent the most common
 cases of /etc/named.conf mutilation.

Comment 2 Bug Zapper 2010-03-15 13:37:36 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 13 development cycle.
Changing version to '13'.

More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 3 Paul Wouters 2010-08-26 18:29:55 UTC
This is now a dead package and has been obsoleted. a yum update should remove it from all systems


Note You need to log in before you can comment on or make changes to this bug.