Spec URL: http://www.excelsiorsystems.net/media/files/python-virtualenv.spec SRPM URL: http://www.excelsiorsystems.net/media/files/python-virtualenv-1.4.3-1.fc11.src.rpm Description: virtualenv is a tool to create isolated Python environments. The basic problem being addressed is one of dependencies and versions, and indirectly permissions. Imagine you have an application that needs version 1 of LibFoo, but another application requires version 2. How can you use both these applications? If you install everything into ``/usr/lib/python2.4/site-packages`` (or whatever your platform's standard location is), it's easy to end up in a situation where you unintentionally upgrade an application that shouldn't be upgraded.
Just some quick comment on your spec file. - Can you please remove the spaces in the description? - The %doc part needs some work. There are some duplicate. - There are two source tarballs (pip and distribute) in the Source RPM. What is the reason that those files are included?
I updated the srpm. I removed all the spaces in the description that were extra. I fixed the %doc section by removing the _build directory and its files. I removed the virtual_support files from the pythong path. It's included, because it's included upstream. It's included upstream, because the same author develops all the other packages. It allows for installation without hitting the network again. I don't install them at least.
Could you post the new url to the spec file? The one above should be an old one, because there are still the spaces. Just some other comments: - %gobal over %define see: https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define - BR: python-setuptools-devel is not needed, python-setuptools is enought - How about modifying the description a bit? You could use %{python_sitelib} instead of ``/usr/lib/python2.4/site-packages``, so the example in the description will always be uptodate.
I actually am not sure why the define was there at all, because I wasn't using it. I removed the define. I changed python-setuptools-devel just to python-setuptools. I changed the description as you suggested. I also updated both the spec file and the SRPM as per the changes to the original URL.
Is there anything else needed from this? I'm wondering if someone else already packages this, because I see this: https://admin.fedoraproject.org/updates/search/python-virtualenv. I see it hasn't been pushed to EL-5 though, which is what I'm really wanting.
(In reply to comment #5) > > I'm wondering if someone else already packages this Do you remember your own review bug #519615 ? -> Closing as dub of the original review. *** This bug has been marked as a duplicate of bug 460182 ***