Created attachment 379730 [details] Minor xinit script improvements The attached patch does the following: - Eliminate dependency on which. - Change Xclients, Xsession and xinitrc-common to make fewer stat calls. - Install xinitrc-common non-executable.
Comment on attachment 379730 [details] Minor xinit script improvements I think I would rather see review of some parts by Søren (e.g., isn't -d "$XCLIENTS_D" a good thing to have?).
(In reply to comment #1) > isn't -d "$XCLIENTS_D" a good thing to have? In both cases where I dropped it the same "if" statement also always tests '-x "$XCLIENTS_D/Xclients.$1.sh"' which is required to be true or else the whole statement evaluates to false, and if $XCLIENTS_D is not a dir (or a symlink to one, but that's transparent when using -d), that test can't evaluate to true. So I don't know what the additional -d test buys us.
http://koji.fedoraproject.org/koji/buildinfo?buildID=153532 built.
xorg-x11-xinit-1.0.9-14.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/xorg-x11-xinit-1.0.9-14.fc12
xorg-x11-xinit-1.0.9-14.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.