Bug 549556 - Review Request: perl-WebService-Google-Language - Perl interface to the Google AJAX Language API
Summary: Review Request: perl-WebService-Google-Language - Perl interface to the Googl...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Iain Arnell
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-12-21 23:21 UTC by Emmanuel Seyman
Modified: 2010-02-01 01:15 UTC (History)
3 users (show)

Fixed In Version: 0.10-2.fc12
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-02-01 01:09:51 UTC
Type: ---
Embargoed:
iarnell: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Comment 1 Iain Arnell 2010-01-17 12:26:00 UTC
+ source files match upstream.  
  4b7697b79880c574d9e6b9d326d4632e  WebService-Google-Language-0.10.tar.gz

+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ summary is OK.
+ description is OK.
+ dist tag is present.
+ build root is OK.
+ license field matches the actual license.
  GPL+ or Artistic

+ license is open source-compatible.
+ license text not included upstream.
+ latest version is being packaged.
- BuildRequires are proper.
  missing perl(Test::Pod) and perl(Test::Pod::Coverage)

+ compiler flags are appropriate.
+ %clean is present.
+ package builds in mock
  http://koji.fedoraproject.org/koji/taskinfo?taskID=1927999

+ package installs properly.
+ rpmlint has no complaints:
  perl-WebService-Google-Language.noarch: I: checking
  perl-WebService-Google-Language.src: I: checking
  2 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ final provides and requires are sane:
  perl(WebService::Google::Language) = 0.10
  perl(WebService::Google::Language::Result)  
  perl-WebService-Google-Language = 0.10-1.fc13
=
  perl >= 0:5.006
  perl(:MODULE_COMPAT_5.10.1)  
  perl(Carp)  
  perl(JSON) >= 2.0
  perl(LWP::UserAgent)  
  perl(URI)  
  perl(constant)  
  perl(strict)  
  perl(warnings)  
  rpmlib(CompressedFileNames) <= 3.0.4-1
  rpmlib(FileDigests) <= 4.6.0-1
  rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  rpmlib(VersionedDependencies) <= 3.0.3-1
  rpmlib(PayloadIsXz) <= 5.2-1

+ %check is present and all tests pass.
  pod and pod-coverage tests are skipped, but otherwise,
  All tests successful.
  Files=6, Tests=45,  0 wallclock secs ( 0.03 usr  0.01 sys +  0.39 cusr  0.04 csys =  0.47 CPU)
  Result: PASS

+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no generically named files
+ code, not content.
+ documentation is small, so no -doc subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.


I think you should add BuildRequires for perl(Test::Pod) and perl(Test::Pod::Coverage) to complete the test suite. 

APPROVED.

(and if you're in a review swapping mood, bug #532190 should be another easy one)

Comment 2 Emmanuel Seyman 2010-01-17 12:58:26 UTC
(In reply to comment #1)
>
> I think you should add BuildRequires for perl(Test::Pod) and
> perl(Test::Pod::Coverage) to complete the test suite. 

I've added perl(Test::Pod) (don't know how I missed the first time around)
but not perl(Test::Pod::Coverage).

> APPROVED.

Thanks, Ian. Requesting CVS.

New Package CVS Request
=======================
Package Name: perl-WebService-Google-Language
Short Description: Perl interface to the Google AJAX Language API
Owners: eseyman
Branches: F-11 F-12
InitialCC: perl-sig

> (and if you're in a review swapping mood, bug #532190 should be another easy
> one)    

Sounds good.

Comment 3 Jason Tibbitts 2010-01-19 18:08:31 UTC
CVS done (by process-cvs-requests.py).

Comment 4 Fedora Update System 2010-01-19 19:57:08 UTC
perl-WebService-Google-Language-0.10-2.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/perl-WebService-Google-Language-0.10-2.fc12

Comment 5 Fedora Update System 2010-01-19 19:57:12 UTC
perl-WebService-Google-Language-0.10-2.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/perl-WebService-Google-Language-0.10-2.fc11

Comment 6 Fedora Update System 2010-01-21 00:04:57 UTC
perl-WebService-Google-Language-0.10-2.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update perl-WebService-Google-Language'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2010-0816

Comment 7 Fedora Update System 2010-01-21 00:05:14 UTC
perl-WebService-Google-Language-0.10-2.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update perl-WebService-Google-Language'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-0818

Comment 8 Fedora Update System 2010-02-01 01:09:46 UTC
perl-WebService-Google-Language-0.10-2.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2010-02-01 01:15:28 UTC
perl-WebService-Google-Language-0.10-2.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.